Re: [PATCH 08/12] fs: export fs_holder_ops

Jan Kara
2023-08-03T13:17:34Z

On Wed 02-08-23 17:41:27, Christoph Hellwig wrote:
> Export fs_holder_ops so that file systems that open additional block
> devices can use it as well.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

Honza

> ---
> fs/super.c | 3 ++-
> include/linux/blkdev.h | 2 ++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fs/super.c b/fs/super.c
> index 0cda4af0a7e16c..dac05f96ab9ac8 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1244,9 +1244,10 @@ static void fs_mark_dead(struct block_device *bdev)
> up_read(&sb->s_umount);
> }
>
> -static const struct blk_holder_ops fs_holder_ops = {
> +const struct blk_holder_ops fs_holder_ops = {
> .mark_dead = fs_mark_dead,
> };
> +EXPORT_SYMBOL_GPL(fs_holder_ops);
>
> static int set_bdev_super(struct super_block *s, void *data)
> {
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index ed44a997f629f5..83262702eea71a 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1464,6 +1464,8 @@ struct blk_holder_ops {
> void (*mark_dead)(struct block_device *bdev);
> };
>
> +extern const struct blk_holder_ops fs_holder_ops;
> +
> /*
> * Return the correct open flags for blkdev_get_by_* for super block flags
> * as stored in sb->s_flags.
> --
> 2.39.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR