From: Atul Kumar Pant <atulpant.linux@gmail.com>
To: josef@toxicpanda.com, axboe@kernel.dk
Cc: Atul Kumar Pant <atulpant.linux@gmail.com>,
linux-block@vger.kernel.org, nbd@other.debian.org,
shuah@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH v1] drivers: block: Updates return value check
Date: Sun, 6 Aug 2023 17:53:51 +0530 [thread overview]
Message-ID: <20230806122351.157168-1-atulpant.linux@gmail.com> (raw)
Updating the check of return value from debugfs_create_dir
to use IS_ERR.
Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
---
drivers/block/nbd.c | 4 ++--
drivers/block/pktcdvd.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 9c35c958f2c8..65ecde3e2a5b 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -1666,7 +1666,7 @@ static int nbd_dev_dbg_init(struct nbd_device *nbd)
return -EIO;
dir = debugfs_create_dir(nbd_name(nbd), nbd_dbg_dir);
- if (!dir) {
+ if (IS_ERR(dir)) {
dev_err(nbd_to_dev(nbd), "Failed to create debugfs dir for '%s'\n",
nbd_name(nbd));
return -EIO;
@@ -1692,7 +1692,7 @@ static int nbd_dbg_init(void)
struct dentry *dbg_dir;
dbg_dir = debugfs_create_dir("nbd", NULL);
- if (!dbg_dir)
+ if (IS_ERR(dbg_dir))
return -EIO;
nbd_dbg_dir = dbg_dir;
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index d5d7884cedd4..69e5a100b3cf 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -451,7 +451,7 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
if (!pkt_debugfs_root)
return;
pd->dfs_d_root = debugfs_create_dir(pd->name, pkt_debugfs_root);
- if (!pd->dfs_d_root)
+ if (IS_ERR(pd->dfs_d_root))
return;
pd->dfs_f_info = debugfs_create_file("info", 0444,
--
2.25.1
next reply other threads:[~2023-08-06 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 12:23 Atul Kumar Pant [this message]
2023-08-06 13:36 ` [PATCH v1] drivers: block: Updates return value check Greg KH
2023-08-07 11:44 ` Atul Kumar Pant
2023-08-08 8:08 ` Greg KH
2023-08-15 20:32 ` Atul Kumar Pant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230806122351.157168-1-atulpant.linux@gmail.com \
--to=atulpant.linux@gmail.com \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=nbd@other.debian.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).