From: Greg KH <gregkh@linuxfoundation.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>,
Satya Tangirala <satyat@google.com>,
linux-block@vger.kernel.org, kernel-team@meta.com,
ebiggers@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] blk-crypto: dynamically allocate fallback profile
Date: Thu, 10 Aug 2023 06:53:04 +0200 [thread overview]
Message-ID: <2023081023-parsnip-limb-dcd4@gregkh> (raw)
In-Reply-To: <94c661a6-442b-4ca2-b9e8-198069d8b635@kernel.dk>
On Wed, Aug 09, 2023 at 04:08:52PM -0600, Jens Axboe wrote:
> On 8/9/23 6:56 AM, Sweet Tea Dorminy wrote:
> > blk_crypto_profile_init() calls lockdep_register_key(), which warns and
> > does not register if the provided memory is a static object.
> > blk-crypto-fallback currently has a static blk_crypto_profile and calls
> > blk_crypto_profile_init() thereupon, resulting in the warning and
> > failure to register.
> >
> > Fortunately it is simple enough to use a dynamically allocated profile
> > and make lockdep function correctly.
> >
> > Fixes: 2fb48d88e77f ("blk-crypto: use dynamic lock class for blk_crypto_profile::lock")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
>
> The offending commit went into 6.5, so there should be no need for a
> stable tag on this one. But I can edit that while applying, waiting on
> Eric to ack it.
That commit has been backported to stable releases, so it would be nice
to keep it there so our tools automatically pick it up properly. Once
the authorship name is fixed up of course.
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-10 4:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 12:56 [PATCH v2] blk-crypto: dynamically allocate fallback profile Sweet Tea Dorminy
2023-08-09 21:57 ` Bart Van Assche
2023-08-10 12:34 ` Sweet Tea Dorminy
2023-08-09 22:08 ` Jens Axboe
2023-08-10 4:53 ` Greg KH [this message]
2023-08-10 13:18 ` Jens Axboe
2023-08-10 13:41 ` Greg KH
2023-08-10 14:31 ` Jens Axboe
2023-08-10 4:59 ` Eric Biggers
2023-08-10 12:39 ` Sweet Tea Dorminy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023081023-parsnip-limb-dcd4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=ebiggers@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=satyat@google.com \
--cc=stable@vger.kernel.org \
--cc=sweettea-kernel@dorminy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox