Re: [PATCH] ublk: fix 'warn: variable dereferenced before check 'req'' from Smatch

Jens Axboe
2023-08-11T14:13:38Z

On Fri, 11 Aug 2023 21:52:16 +0800, Ming Lei wrote:
> The added check of 'req_op(req) == REQ_OP_ZONE_APPEND' should have been
> done after the request is confirmed as valid.
>
> Actually here, the request should always been true, so add one
> WARN_ON_ONCE(!req), meantime move the zone_append check after
> checking the request.
>
> [...]

Applied, thanks!

[1/1] ublk: fix 'warn: variable dereferenced before check 'req'' from Smatch
commit: e24721e441a7c640e4e7b2b63c23c06d9a750880

Best regards,
--
Jens Axboe