From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
Can Guo <quic_cang@quicinc.com>,
Avri Altman <avri.altman@wdc.com>,
"Bao D . Nguyen" <quic_nguyenb@quicinc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Zhe Wang <zhe.wang1@unisoc.com>
Subject: [PATCH v10 14/18] scsi: ufs: sprd: Rework the code for disabling auto-hibernation
Date: Fri, 18 Aug 2023 12:34:17 -0700 [thread overview]
Message-ID: <20230818193546.2014874-15-bvanassche@acm.org> (raw)
In-Reply-To: <20230818193546.2014874-1-bvanassche@acm.org>
Call ufshcd_auto_hibern8_update() instead of writing directly into the
auto-hibernation control register. This patch is part of an effort to
move all auto-hibernation register changes into the UFSHCI driver core.
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Can Guo <quic_cang@quicinc.com>
Cc: Avri Altman <avri.altman@wdc.com>
Cc: Bao D. Nguyen <quic_nguyenb@quicinc.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/host/ufs-sprd.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/ufs/host/ufs-sprd.c b/drivers/ufs/host/ufs-sprd.c
index 2bad75dd6d58..15a1876656a7 100644
--- a/drivers/ufs/host/ufs-sprd.c
+++ b/drivers/ufs/host/ufs-sprd.c
@@ -180,15 +180,8 @@ static int sprd_ufs_pwr_change_notify(struct ufs_hba *hba,
static int ufs_sprd_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op,
enum ufs_notify_change_status status)
{
- unsigned long flags;
-
- if (status == PRE_CHANGE) {
- if (ufshcd_is_auto_hibern8_supported(hba)) {
- spin_lock_irqsave(hba->host->host_lock, flags);
- ufshcd_writel(hba, 0, REG_AUTO_HIBERNATE_IDLE_TIMER);
- spin_unlock_irqrestore(hba->host->host_lock, flags);
- }
- }
+ if (status == PRE_CHANGE)
+ WARN_ON_ONCE(ufshcd_auto_hibern8_update(hba, 0) != 0);
return 0;
}
next prev parent reply other threads:[~2023-08-18 19:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 19:34 [PATCH v10 00/18] Improve performance for zoned UFS devices Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 01/18] block: Introduce more member variables related to zone write locking Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 02/18] block: Only use write locking if necessary Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 03/18] block/mq-deadline: Only use zone " Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 04/18] scsi: core: Introduce a mechanism for reordering requests in the error handler Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 05/18] scsi: core: Add unit tests for scsi_call_prepare_resubmit() Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 06/18] scsi: sd: Sort commands by LBA before resubmitting Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 07/18] scsi: core: Retry unaligned zoned writes Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 08/18] scsi: sd_zbc: Only require an I/O scheduler if needed Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 09/18] scsi: scsi_debug: Add the preserves_write_order module parameter Bart Van Assche
2023-08-22 4:05 ` Douglas Gilbert
2023-08-18 19:34 ` [PATCH v10 10/18] scsi: scsi_debug: Support injecting unaligned write errors Bart Van Assche
2023-08-18 19:34 ` [PATCH v10 11/18] scsi: ufs: Change the return type of ufshcd_auto_hibern8_update() Bart Van Assche
2023-08-18 21:05 ` Bao D. Nguyen
2023-08-21 5:30 ` Can Guo
2023-08-18 19:34 ` [PATCH v10 12/18] scsi: ufs: hisi: Rework the code that disables auto-hibernation Bart Van Assche
2023-08-18 21:09 ` Bao D. Nguyen
2023-08-18 19:34 ` [PATCH v10 13/18] scsi: ufs: mediatek: Rework the code for disabling auto-hibernation Bart Van Assche
2023-08-18 21:11 ` Bao D. Nguyen
2023-08-22 9:20 ` Peter Wang (王信友)
2023-08-22 15:54 ` Bart Van Assche
2023-08-18 19:34 ` Bart Van Assche [this message]
2023-08-18 21:14 ` [PATCH v10 14/18] scsi: ufs: sprd: " Bao D. Nguyen
2023-08-18 19:34 ` [PATCH v10 15/18] scsi: ufs: Rename ufshcd_auto_hibern8_enable() and make it static Bart Van Assche
2023-08-18 21:15 ` Bao D. Nguyen
2023-08-21 5:34 ` Can Guo
2023-08-18 19:34 ` [PATCH v10 16/18] scsi: ufs: Simplify ufshcd_auto_hibern8_update() Bart Van Assche
2023-08-18 21:16 ` Bao D. Nguyen
2023-08-21 5:35 ` Can Guo
2023-08-18 19:34 ` [PATCH v10 17/18] scsi: ufs: Forbid auto-hibernation without I/O scheduler Bart Van Assche
2023-08-18 21:17 ` Bao D. Nguyen
2023-08-21 5:44 ` Can Guo
2023-08-21 7:13 ` Can Guo
2023-08-18 19:34 ` [PATCH v10 18/18] scsi: ufs: Inform the block layer about write ordering Bart Van Assche
2023-08-18 21:19 ` Bao D. Nguyen
2023-08-21 7:15 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818193546.2014874-15-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=baolin.wang@linux.alibaba.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=orsonzhai@gmail.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=zhang.lyra@gmail.com \
--cc=zhe.wang1@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).