Re: [PATCH 20/29] btrfs: Convert to bdev_open_by_path()

Christian Brauner
2023-08-25T12:29:19Z

On Wed, Aug 23, 2023 at 12:48:31PM +0200, Jan Kara wrote:
> Convert btrfs to use bdev_open_by_path() and pass the handle around. We
> also drop the holder from struct btrfs_device as it is now not needed
> anymore.
>
> CC: David Sterba <dsterba@suse.com>
> CC: linux-btrfs@vger.kernel.org
> Acked-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---

Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>

> - bdev = blkdev_get_by_path(path, BLK_OPEN_READ, NULL, NULL);
> - if (IS_ERR(bdev))
> - return ERR_CAST(bdev);
> + bdev_handle = bdev_open_by_path(path, BLK_OPEN_READ, NULL, NULL);
> + if (IS_ERR(bdev_handle))
> + return ERR_CAST(bdev_handle);

Minor merge conflict with what's in vfs.super because we dropped
unrelated btrfs patches like David asked us to. Very easy to fix for me.
Just an fyi.