From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
"Bao D . Nguyen" <quic_nguyenb@quicinc.com>,
Can Guo <quic_cang@quicinc.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Asutosh Das <quic_asutoshd@quicinc.com>,
Bean Huo <beanhuo@micron.com>,
Arthur Simchaev <Arthur.Simchaev@wdc.com>,
Po-Wen Kao <powen.kao@mediatek.com>,
Eric Biggers <ebiggers@google.com>,
Keoseong Park <keosung.park@samsung.com>
Subject: [PATCH v14 15/19] scsi: ufs: Rename ufshcd_auto_hibern8_enable() and make it static
Date: Mon, 23 Oct 2023 14:54:06 -0700 [thread overview]
Message-ID: <20231023215638.3405959-16-bvanassche@acm.org> (raw)
In-Reply-To: <20231023215638.3405959-1-bvanassche@acm.org>
Rename ufshcd_auto_hibern8_enable() into ufshcd_configure_auto_hibern8()
since this function can enable or disable auto-hibernation. Since
ufshcd_auto_hibern8_enable() is only used inside the UFSHCI driver core,
declare it static. Additionally, move the definition of this function to
just before its first caller.
Suggested-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>
Reviewed-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>
Reviewed-by: Can Guo <quic_cang@quicinc.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/core/ufshcd.c | 24 +++++++++++-------------
include/ufs/ufshcd.h | 1 -
2 files changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index c2df07545f96..38e79ce05545 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -4305,6 +4305,14 @@ int ufshcd_uic_hibern8_exit(struct ufs_hba *hba)
}
EXPORT_SYMBOL_GPL(ufshcd_uic_hibern8_exit);
+static void ufshcd_configure_auto_hibern8(struct ufs_hba *hba)
+{
+ if (!ufshcd_is_auto_hibern8_supported(hba))
+ return;
+
+ ufshcd_writel(hba, hba->ahit, REG_AUTO_HIBERNATE_IDLE_TIMER);
+}
+
void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit)
{
unsigned long flags;
@@ -4324,21 +4332,13 @@ void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit)
!pm_runtime_suspended(&hba->ufs_device_wlun->sdev_gendev)) {
ufshcd_rpm_get_sync(hba);
ufshcd_hold(hba);
- ufshcd_auto_hibern8_enable(hba);
+ ufshcd_configure_auto_hibern8(hba);
ufshcd_release(hba);
ufshcd_rpm_put_sync(hba);
}
}
EXPORT_SYMBOL_GPL(ufshcd_auto_hibern8_update);
-void ufshcd_auto_hibern8_enable(struct ufs_hba *hba)
-{
- if (!ufshcd_is_auto_hibern8_supported(hba))
- return;
-
- ufshcd_writel(hba, hba->ahit, REG_AUTO_HIBERNATE_IDLE_TIMER);
-}
-
/**
* ufshcd_init_pwr_info - setting the POR (power on reset)
* values in hba power info
@@ -8757,8 +8757,7 @@ static int ufshcd_probe_hba(struct ufs_hba *hba, bool init_dev_params)
if (hba->ee_usr_mask)
ufshcd_write_ee_control(hba);
- /* Enable Auto-Hibernate if configured */
- ufshcd_auto_hibern8_enable(hba);
+ ufshcd_configure_auto_hibern8(hba);
out:
spin_lock_irqsave(hba->host->host_lock, flags);
@@ -9744,8 +9743,7 @@ static int __ufshcd_wl_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
cancel_delayed_work(&hba->rpm_dev_flush_recheck_work);
}
- /* Enable Auto-Hibernate if configured */
- ufshcd_auto_hibern8_enable(hba);
+ ufshcd_configure_auto_hibern8(hba);
goto out;
diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
index 7d07b256e906..fceef91d186e 100644
--- a/include/ufs/ufshcd.h
+++ b/include/ufs/ufshcd.h
@@ -1356,7 +1356,6 @@ static inline int ufshcd_disable_host_tx_lcc(struct ufs_hba *hba)
return ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);
}
-void ufshcd_auto_hibern8_enable(struct ufs_hba *hba);
void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit);
void ufshcd_fixup_dev_quirks(struct ufs_hba *hba,
const struct ufs_dev_quirk *fixups);
next prev parent reply other threads:[~2023-10-23 21:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 21:53 [PATCH v14 00/19] Improve write performance for zoned UFS devices Bart Van Assche
2023-10-23 21:53 ` [PATCH v14 01/19] block: Introduce more member variables related to zone write locking Bart Van Assche
2023-10-23 21:53 ` [PATCH v14 02/19] block: Only use write locking if necessary Bart Van Assche
2023-10-23 23:29 ` Damien Le Moal
2023-10-23 21:53 ` [PATCH v14 03/19] block: Preserve the order of requeued zoned writes Bart Van Assche
2023-10-23 23:30 ` Damien Le Moal
2023-10-23 21:53 ` [PATCH v14 04/19] block/mq-deadline: Only use zone locking if necessary Bart Van Assche
2023-10-23 21:53 ` [PATCH v14 05/19] scsi: Add an argument to scsi_eh_flush_done_q() Bart Van Assche
2023-10-24 0:07 ` Damien Le Moal
2023-10-24 9:26 ` John Garry
2023-10-24 17:17 ` Bart Van Assche
2023-10-24 18:20 ` John Garry
2023-10-23 21:53 ` [PATCH v14 06/19] scsi: core: Introduce a mechanism for reordering requests in the error handler Bart Van Assche
2023-10-24 0:09 ` Damien Le Moal
2023-10-23 21:53 ` [PATCH v14 07/19] scsi: core: Add unit tests for scsi_call_prepare_resubmit() Bart Van Assche
2023-10-23 21:53 ` [PATCH v14 08/19] scsi: sd: Sort commands by LBA before resubmitting Bart Van Assche
2023-10-24 0:11 ` Damien Le Moal
2023-10-23 21:54 ` [PATCH v14 09/19] scsi: sd: Add a unit test for sd_cmp_sector() Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 10/19] scsi: core: Retry unaligned zoned writes Bart Van Assche
2023-10-24 0:13 ` Damien Le Moal
2023-10-24 17:22 ` Bart Van Assche
2023-10-25 7:25 ` Damien Le Moal
2023-10-25 19:28 ` Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 11/19] scsi: sd_zbc: Only require an I/O scheduler if needed Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 12/19] scsi: scsi_debug: Add the preserves_write_order module parameter Bart Van Assche
2023-10-24 0:13 ` Damien Le Moal
2023-10-24 17:25 ` Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 13/19] scsi: scsi_debug: Support injecting unaligned write errors Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 14/19] scsi: ufs: hisi: Rework the code that disables auto-hibernation Bart Van Assche
2023-10-23 21:54 ` Bart Van Assche [this message]
2023-10-23 21:54 ` [PATCH v14 16/19] scsi: ufs: Change the return type of ufshcd_auto_hibern8_update() Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 17/19] scsi: ufs: Simplify ufshcd_auto_hibern8_update() Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 18/19] scsi: ufs: Forbid auto-hibernation without I/O scheduler Bart Van Assche
2023-10-23 21:54 ` [PATCH v14 19/19] scsi: ufs: Inform the block layer about write ordering Bart Van Assche
2023-10-23 23:43 ` [PATCH v14 00/19] Improve write performance for zoned UFS devices Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023215638.3405959-16-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=Arthur.Simchaev@wdc.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=beanhuo@micron.com \
--cc=ebiggers@google.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=keosung.park@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=powen.kao@mediatek.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).