Re: [PATCH 3/6] xfs: Block writes to log device

Darrick J. Wong
2023-07-04T15:53:17Z

On Tue, Jul 04, 2023 at 02:56:51PM +0200, Jan Kara wrote:
> Ask block layer to not allow other writers to open block device used
> for xfs log.

"...for the xfs log and realtime devices."

With that fixed,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/xfs/xfs_super.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index b0fbf8ea7846..3808b4507552 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -396,8 +396,9 @@ xfs_blkdev_get(
> {
> int error = 0;
>
> - *handlep = blkdev_get_by_path(name, BLK_OPEN_READ | BLK_OPEN_WRITE,
> - mp, &xfs_holder_ops);
> + *handlep = blkdev_get_by_path(name,
> + BLK_OPEN_READ | BLK_OPEN_WRITE | BLK_OPEN_BLOCK_WRITES,
> + mp, &xfs_holder_ops);
> if (IS_ERR(*handlep)) {
> error = PTR_ERR(*handlep);
> xfs_warn(mp, "Invalid device [%s], error=%d", name, error);
> --
> 2.35.3
>