Re: [PATCHv2 1/4] block: bio-integrity: directly map user buffers

Keith Busch
2023-10-30T14:54:12Z

On Mon, Oct 30, 2023 at 03:40:47PM +0100, Pankaj Raghav wrote:
> > + int ret;
> > +
> > + /* if bvec is on the stack, we need to allocate a copy for the completion */
> > + if (nr_vecs <= UIO_FASTIOV) {
> > + copy_vec = kcalloc(sizeof(*bvec), nr_vecs, GFP_KERNEL);
> > + if (!copy_vec)
> > + return -ENOMEM;
> > + memcpy(copy_vec, bvec, nr_vecs * sizeof(*bvec));
> > + }
> > +
> > + buf = kmalloc(len, GFP_KERNEL);
> > + if (!buf)
> > + goto free_copy;
>
> ret is not set to -ENOMEM here.

Indeed, thanks for pointing that out. I'll wait a bit longer before
posting a v3.