From: Christoph Hellwig <hch@lst.de>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: hch@lst.de, ming.lei@redhat.com, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH v4 2/2] block: warn once for each partition in bio_check_ro()
Date: Tue, 28 Nov 2023 14:00:00 +0100 [thread overview]
Message-ID: <20231128130000.GB7984@lst.de> (raw)
In-Reply-To: <20231128123027.971610-3-yukuai1@huaweicloud.com>
On Tue, Nov 28, 2023 at 08:30:27PM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> Commit 1b0a151c10a6 ("blk-core: use pr_warn_ratelimited() in
> bio_check_ro()") fix message storm by limit the rate, however, there
> will still be lots of message in the long term. Fix it better by warn
> once for each partition.
The new field is in the same dword alignment as bd_make_it_fail and
could in theory corrupt it, at least on alpha. I guess we're fine,
because if you enable CONFIG_FAIL_MAKE_REQUEST on alpha you're asking
for this. I still hope we can clean up these non-atomic bools and
replace them with bitops soon.
Signed-off-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-11-28 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 12:30 [PATCH v4 0/2] block: warn once for each partition in bio_check_ro() Yu Kuai
2023-11-28 12:30 ` [PATCH v4 1/2] block: move .bd_inode into 1st cacheline of block_device Yu Kuai
2023-11-28 12:58 ` Christoph Hellwig
2023-11-28 12:30 ` [PATCH v4 2/2] block: warn once for each partition in bio_check_ro() Yu Kuai
2023-11-28 13:00 ` Christoph Hellwig [this message]
2023-11-29 1:13 ` Yu Kuai
2023-11-28 19:11 ` [PATCH v4 0/2] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128130000.GB7984@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox