From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC67E39AF3; Tue, 19 Dec 2023 22:50:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sjtxOuKo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C0B0C433C7; Tue, 19 Dec 2023 22:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703026250; bh=s1/+bxxcBS5WdK2rZ7PUQ8eT9olEr2/GFE7anYexsbY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sjtxOuKo7Ry2RXRmW17ZDHXUg592bnDvwFYHZ5OGTP5iTuAlky9OGLMRQnJ5plZEh LrW9+Dotar44nCjaEEW9AaX2kKLdddmmcPm+olaF7Zw2mLCLAFk9RlFZhHBtC+Kps8 w5ECG27E6sJC+wWcU7VX8TVWNrwhzBt5rJVBR2IFH5ytfDEpfy3h4Fe+Ky4Ipz/b5c vp1WbSUhQQLPpXANIo9v25KK18xoZ5zHYxWJpZ5jmnAn9ZDnKcBLsjvDP7s1SYPPpx /YiLet7Yw++98ile+dI51CrUmt2ojD9U/73JN0vN5gWVecJ6ceu14KIDwxAa8lwtMT EKfw2TMrQNaNA== Date: Tue, 19 Dec 2023 15:50:48 -0700 From: Eric Biggers To: Hongyu Jin Cc: agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com, axboe@kernel.dk, zhiguo.niu@unisoc.com, ke.wang@unisoc.com, yibin.ding@unisoc.com, hongyu.jin@unisoc.com, linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev, linux-block@vger.kernel.org Subject: Re: [PATCH v5 RESEND 5/5] dm-crypt: Fix lost ioprio when queuing write bios Message-ID: <20231219224943.GD38652@quark.localdomain> References: <20231218012746.24442-1-hongyu.jin.cn@gmail.com> <20231218012746.24442-6-hongyu.jin.cn@gmail.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218012746.24442-6-hongyu.jin.cn@gmail.com> On Mon, Dec 18, 2023 at 09:27:46AM +0800, Hongyu Jin wrote: > From: Hongyu Jin > > The original submitting bio->bi_ioprio setting can be retained by > struct dm_crypt_io::base_bio, we set the original bio's ioprio to > the cloned bio for write. This commit message does not make sense. Can you make the commit message properly describe the problem and how the patch fixes it? - Eric