From: Muneendra Kumar M <muneendra.kumar@broadcom.com>
To: Hannes Reinecke <hare@suse.de>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
tj@kernel.org, linux-nvme@lists.infradead.org
Cc: jsmart2021@gmail.com, emilne@redhat.com, mkumar@redhat.com,
pbonzini@redhat.com
Subject: RE: [PATCH v4 02/19] blkcg: Added a app identifier support for blkcg
Date: Wed, 18 Nov 2020 15:09:57 +0530 [thread overview]
Message-ID: <20235961dc048bb4abfc4fe42d080f9a@mail.gmail.com> (raw)
In-Reply-To: <1a779905-e1d2-1c3b-1825-7a406e9b5ed6@suse.de>
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
Hi Hannes,
Thanks for the review.
> + ret = -EINVAL;
> + goto out_put;
> + }
> + strlcpy(blkcg->fc_app_id, buf, len);
>String or UUID?
>And will it be NULL-terminated?
>Wouldn't it be better to use 'memcpy' here?
>And it is NULL terminated: what happens if the user sets a 128-byte string?
>IE shouldn't the app_id be 129 bytes long if it's assumed to be
>NULL-terminated?
[Muneendra]It is a string and it is NULL terminated.
Agreed it should be 129 bytes long.
Regards,
Muneendra.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4177 bytes --]
next prev parent reply other threads:[~2020-11-18 9:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 4:23 [PATCH v4 00/19] blkcg:Support to track FC storage blk io traffic Muneendra
2020-11-09 4:23 ` [PATCH v4 01/19] cgroup: Added cgroup_get_from_kernfs_id Muneendra
2020-11-16 7:25 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 02/19] blkcg: Added a app identifier support for blkcg Muneendra
2020-11-09 13:55 ` Tejun Heo
2020-11-16 7:31 ` Hannes Reinecke
2020-11-18 9:39 ` Muneendra Kumar M [this message]
2020-11-09 4:23 ` [PATCH v4 03/19] nvme: Added a newsysfs attribute appid_store Muneendra
2020-11-16 7:39 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 04/19] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra
2020-11-16 7:41 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 05/19] lpfc: vmid: API to check if VMID is enabled Muneendra
2020-11-16 7:44 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 06/19] lpfc: vmid: Supplementary data structures for vmid Muneendra
2020-11-16 7:49 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 07/19] lpfc: vmid: Forward declarations for APIs Muneendra
2020-11-16 7:50 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 08/19] lpfc: vmid: Add support for vmid in mailbox command Muneendra
2020-11-16 7:52 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 09/19] lpfc: vmid: VMID params initialization Muneendra
2020-11-16 7:53 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 10/19] lpfc: vmid: vmid resource allocation Muneendra
2020-11-16 7:56 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 11/19] lpfc: vmid: cleanup vmid resources Muneendra
2020-11-16 7:56 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 12/19] lpfc: vmid: Implements ELS commands for appid patch Muneendra
2020-11-16 8:03 ` Hannes Reinecke
2020-11-09 4:23 ` [PATCH v4 13/19] lpfc: vmid: Functions to manage vmids Muneendra
2020-11-16 8:06 ` Hannes Reinecke
2020-11-09 4:24 ` [PATCH v4 14/19] lpfc: vmid: Implements CT commands for appid Muneendra
2020-11-16 8:08 ` Hannes Reinecke
2020-11-09 4:24 ` [PATCH v4 15/19] lpfc: vmid: Appends the vmid in the wqe before sending request Muneendra
2020-11-16 8:10 ` Hannes Reinecke
2020-11-09 4:24 ` [PATCH v4 16/19] lpfc: vmid: Timeout implementation for vmid Muneendra
2020-11-16 8:11 ` Hannes Reinecke
2020-11-09 4:24 ` [PATCH v4 17/19] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra
2020-11-16 8:12 ` Hannes Reinecke
2020-11-09 4:24 ` [PATCH v4 18/19] lpfc: vmid: Introducing vmid in io path Muneendra
2020-11-16 8:13 ` Hannes Reinecke
2020-11-09 4:24 ` [PATCH v4 19/19] scsi: Made changes in Kconfig to select BLK_CGROUP_FC_APPID Muneendra
2020-11-16 8:15 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20235961dc048bb4abfc4fe42d080f9a@mail.gmail.com \
--to=muneendra.kumar@broadcom.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=jsmart2021@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkumar@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).