Re: [PATCH] nvme: add nvme pci timeout testcase

[Nitesh Shetty <nj.shetty@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 1494 bytes --]

On 10/01/24 07:40AM, Chaitanya Kulkarni wrote:
>On 1/9/24 22:17, Nitesh Shetty wrote:
>> On 09/01/24 07:57PM, Chaitanya Kulkarni wrote:
>>> Trigger and test nvme-pci timeout with concurrent fio jobs.
>>>
>>> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
>>> ---
>>> tests/nvme/050     | 43 +++++++++++++++++++++++++++++++++++++++++++
>>> tests/nvme/050.out |  2 ++
>>> 2 files changed, 45 insertions(+)
>>> create mode 100755 tests/nvme/050
>>> create mode 100644 tests/nvme/050.out
>>>
>>> diff --git a/tests/nvme/050 b/tests/nvme/050
>>> new file mode 100755
>>> index 0000000..ba54bcd
>>> --- /dev/null
>>> +++ b/tests/nvme/050
>>> @@ -0,0 +1,43 @@
>>> +#!/bin/bash
>>> +# SPDX-License-Identifier: GPL-3.0+
>>> +# Copyright (C) 2024 Chaitanya Kulkarni.
>>> +#
>>> +# Test NVMe-PCI timeout with FIO jobs by triggering the nvme_timeout
>>> function.
>>> +#
>>> +
>>> +. tests/nvme/rc
>>> +
>>> +DESCRIPTION="test nvme-pci timeout with fio jobs."
>>> +
>>> +requires() {
>>> +    _require_nvme_trtype pci
>>> +    _have_fio
>>> +    _nvme_requires
>>> +}
>>> +
>>> +test() {
>>> +    local dev="/dev/nvme0n1"
>>
>> Should this be TEST_DEV instead ?
>
>why ?
>
My understanding of blktests is, add device which we want to test in
config files under TEST_DEV (except null-blk and nvme-fabrics loopback
devices, which are usually populated inside the tests).
In this case, if someone do not want to disturb nvme0n1 device,
this test doesn't allow it.

Regards,
Nitesh Shetty

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]