From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <ming.lei@redhat.com>, linux-block@vger.kernel.org
Subject: [PATCH 1/2] blk-mq: rename blk_mq_can_use_cached_rq
Date: Thu, 11 Jan 2024 14:57:04 +0100 [thread overview]
Message-ID: <20240111135705.2155518-2-hch@lst.de> (raw)
In-Reply-To: <20240111135705.2155518-1-hch@lst.de>
blk_mq_can_use_cached_rq doesn't just check if we can use the request,
but also performs the work to actually use it. Remove the _can in the
naming, and improve the comment describing the function.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/blk-mq.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index aa9a05fdd02377..a6731cacd0132c 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2884,8 +2884,11 @@ static struct request *blk_mq_get_new_requests(struct request_queue *q,
return NULL;
}
-/* return true if this @rq can be used for @bio */
-static bool blk_mq_can_use_cached_rq(struct request *rq, struct blk_plug *plug,
+/*
+ * Check if we can use the passed on request for submitting the passed in bio,
+ * and remove it from the request list if it can be used.
+ */
+static bool blk_mq_use_cached_rq(struct request *rq, struct blk_plug *plug,
struct bio *bio)
{
enum hctx_type type = blk_mq_get_hctx_type(bio->bi_opf);
@@ -2963,7 +2966,7 @@ void blk_mq_submit_bio(struct bio *bio)
return;
if (blk_mq_attempt_bio_merge(q, bio, nr_segs))
return;
- if (blk_mq_can_use_cached_rq(rq, plug, bio))
+ if (blk_mq_use_cached_rq(rq, plug, bio))
goto done;
percpu_ref_get(&q->q_usage_counter);
} else {
--
2.39.2
next prev parent reply other threads:[~2024-01-11 13:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 13:57 ensure q_usage_counter is held over bio splits Christoph Hellwig
2024-01-11 13:57 ` Christoph Hellwig [this message]
2024-01-11 13:57 ` [PATCH 2/2] blk-mq: ensure a q_usage_counter reference is held when splitting bios Christoph Hellwig
2024-01-11 16:12 ` Jens Axboe
2024-01-11 16:14 ` Christoph Hellwig
2024-01-11 16:17 ` Jens Axboe
2024-01-11 16:18 ` Christoph Hellwig
2024-01-11 17:10 ` Christoph Hellwig
2024-01-11 17:18 ` Jens Axboe
2024-01-11 17:24 ` Christoph Hellwig
2024-01-11 20:06 ` Jens Axboe
2024-01-12 5:44 ` Christoph Hellwig
2024-01-12 14:22 ` Jens Axboe
2024-01-12 14:25 ` Christoph Hellwig
2024-01-12 16:10 ` Jens Axboe
2024-01-15 11:20 ` Ulf Hansson
2024-01-22 7:34 ` mmc vs highmem, was: " Christoph Hellwig
2024-01-22 9:26 ` Arnd Bergmann
2024-01-22 13:39 ` Christoph Hellwig
2024-01-22 14:57 ` Arnd Bergmann
2024-01-23 9:11 ` Christoph Hellwig
2024-01-24 11:59 ` Arnd Bergmann
2024-01-24 12:33 ` Linus Walleij
2024-01-24 12:54 ` Arnd Bergmann
2024-01-24 13:16 ` Linus Walleij
2024-01-24 14:14 ` Arnd Bergmann
2024-01-24 12:45 ` Arnd Bergmann
2024-01-24 13:49 ` Linus Walleij
2024-01-24 16:35 ` Arnd Bergmann
2024-01-11 22:22 ` Ming Lei
2024-01-12 5:46 ` Christoph Hellwig
2024-01-11 16:03 ` ensure q_usage_counter is held over bio splits Jens Axboe
2024-01-14 14:38 ` (subset) " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111135705.2155518-2-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox