Re: [PATCH RFC 2/2] fs,drivers: remove bdev_inode() usage outside of block layer and drivers

Yu Kuai
2024-02-19T13:42:20Z

Hi,

在 2024/01/29 23:36, Christoph Hellwig 写道:
> On Mon, Jan 29, 2024 at 04:29:32PM +0100, Christian Brauner wrote:
>> On Mon, Jan 29, 2024 at 03:37:09PM +0100, Christoph Hellwig wrote:
>>> Most of these really should be using proper high level APIs. The
>>> last round of work on this is here:
>>>
>>> https://lore.kernel.org/linux-nilfs/4b11a311-c121-1f44-0ccf-a3966a396994@huaweicloud.com/
>>
>> Are you saying that I should just drop this patch here?
>
> I think we need to order the work:
>
> - get your use struct file as bdev handle series in
> - rebase the above series on top of that, including some bigger changes
> like block2mtd which can then use normal file read/write APIs

I'm working on that now, mostly convert to use bdev_file, and file_inode
to get 'bd_inode' or f_mapping to get 'bd_inode->f_mapping', and now
that all fs and all drivers can avoid to access 'bd_inode' now.

> - rebase what is left of this series on top of that, and hopefully not
> much of this patch and a lot less of patch 1 will be left at that
> point.

This is done by a huge patch for now, and there really is nothing left
of this set. I'm still testing and spliting into a patchset. I'll post a
RFC version soon.

Thanks,
Kuai

>
> .
>