Re: [PATCH v9 1/5] block: Fix where bio IO priority gets set

Ming Lei
2024-02-01T03:19:51Z

On Tue, Jan 30, 2024 at 03:26:34PM -0500, Mike Snitzer wrote:
> From: Hongyu Jin <hongyu.jin@unisoc.com>
>
> Commit 82b74cac2849 ("blk-ioprio: Convert from rqos policy to direct
> call") pushed setting bio I/O priority down into blk_mq_submit_bio()
> -- which is too low within block core's submit_bio() because it
> skips setting I/O priority for block drivers that implement
> fops->submit_bio() (e.g. DM, MD, etc).
>
> Fix this by moving bio_set_ioprio() up from blk-mq.c to blk-core.c and
> call it from submit_bio(). This ensures all block drivers call
> bio_set_ioprio() during initial bio submission.
>
> Fixes: a78418e6a04c ("block: Always initialize bio IO priority on submit")
> Co-developed-by: Yibin Ding <yibin.ding@unisoc.com>
> Signed-off-by: Yibin Ding <yibin.ding@unisoc.com>
> Signed-off-by: Hongyu Jin <hongyu.jin@unisoc.com>
> Reviewed-by: Eric Biggers <ebiggers@google.com>
> Reviewed-by: Mikulas Patocka <mpatocka@redhat.com>
> [snitzer: revised commit header]
> Signed-off-by: Mike Snitzer <snitzer@kernel.org>

Looks fine,

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming