Re: [PATCH v2 07/34] xfs: port block device access to files

Christoph Hellwig
2024-01-29T16:17:17Z

> if (mp->m_rtname) {
> - error = xfs_blkdev_get(mp, mp->m_rtname, &rtdev_handle);
> + error = xfs_blkdev_get(mp, mp->m_rtname, &rtdev_file);
> if (error)
> goto out_close_logdev;
>
> - if (rtdev_handle->bdev == ddev ||
> - (logdev_handle &&
> - rtdev_handle->bdev == logdev_handle->bdev)) {
> + if (file_bdev(rtdev_file) == ddev ||
> + (logdev_file && file_bdev(rtdev_file) == file_bdev(logdev_file))) {

Please avoid the overly long line here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

(note that this will probably have some not too bad merge conflict
with in-flight xfs work)