From: Kanchan Joshi <joshi.k@samsung.com>
To: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de,
martin.petersen@oracle.com, sagi@grimberg.me
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
gost.dev@samsung.com, Kanchan Joshi <joshi.k@samsung.com>
Subject: [PATCH v2 0/3] Block integrity with flexible-offset PI
Date: Thu, 1 Feb 2024 18:31:23 +0530 [thread overview]
Message-ID: <20240201130126.211402-1-joshi.k@samsung.com> (raw)
In-Reply-To: CGME20240201130828epcas5p10bd98bcb6b8e9444603e347c2a910c44@epcas5p1.samsung.com
The block integrity subsystem can only work with PI placed in the first
bytes of the metadata buffer.
The series makes block-integrity support the flexible placement of PI.
And changes NVMe driver to make use of the new capability.
This helps to
(i) enable the more common case for NVMe (PI in last bytes is the norm)
(ii) reduce nop profile users (tried by Jens recently [1]).
/* For NS 4K+16b, 8b PI, last bytes */
Before:
# cat /sys/block/nvme0n1/integrity/format
nop
After:
# cat /sys/block/nvme0n1/integrity/format
T10-DIF-TYPE1-CRC
Changes since v1:
- Reworded commit messsage in patch 2 and 3 (hch)
- Variable initialization order change (hch)
- Collect reviewed-by
[1] https://lore.kernel.org/linux-block/20240111160226.1936351-1-axboe@kernel.dk/
Kanchan Joshi (3):
block: refactor guard helpers
block: support PI at non-zero offset within metadata
nvme: allow integrity when PI is not in first bytes
block/bio-integrity.c | 1 +
block/blk-integrity.c | 1 +
block/t10-pi.c | 72 +++++++++++++++++++++++------------
drivers/nvme/host/core.c | 8 +++-
drivers/nvme/host/nvme.h | 1 +
include/linux/blk-integrity.h | 1 +
include/linux/blkdev.h | 1 +
7 files changed, 60 insertions(+), 25 deletions(-)
--
2.25.1
next parent reply other threads:[~2024-02-01 13:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240201130828epcas5p10bd98bcb6b8e9444603e347c2a910c44@epcas5p1.samsung.com>
2024-02-01 13:01 ` Kanchan Joshi [this message]
2024-02-01 13:01 ` [PATCH v2 1/3] block: refactor guard helpers Kanchan Joshi
2024-02-01 13:01 ` [PATCH v2 2/3] block: support PI at non-zero offset within metadata Kanchan Joshi
2024-09-26 15:07 ` Keith Busch
2024-09-26 16:38 ` Kanchan Joshi
2024-09-26 16:55 ` Keith Busch
2024-09-27 16:07 ` Kanchan Joshi
2024-09-30 17:57 ` Martin K. Petersen
2024-10-01 7:27 ` Javier González
2024-10-01 15:37 ` Keith Busch
2024-10-02 10:29 ` Javier González
2024-10-02 16:18 ` Martin K. Petersen
2024-10-02 19:03 ` Keith Busch
2024-02-01 13:01 ` [PATCH v2 3/3] nvme: allow integrity when PI is not in first bytes Kanchan Joshi
2024-02-12 15:47 ` [PATCH v2 0/3] Block integrity with flexible-offset PI Kanchan Joshi
2024-02-12 15:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201130126.211402-1-joshi.k@samsung.com \
--to=joshi.k@samsung.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).