From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83977225D6 for ; Mon, 19 Feb 2024 10:47:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708339644; cv=none; b=I5H566gCwXoRMlQ1VdPRKJ6gnCL6yFP55IMWDb9QXONvvDTJYA8cBnL/dwy2DEwamWpb/5JP3qLFcdADer0fDlnGZKy1MZ0XcxKwlicQ3AENej4031zqasmJD1KFbY2AtWum8Z3xXF3jGrWkV3NyF7d9abuzH9LtuMS8Op6U50A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708339644; c=relaxed/simple; bh=CbS8EfhDRka7Q6wEyhHmEPKriZqIsMZYy+gfG/xziFs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xydz7BLcrMQUxoKlHj8SYydcfJiU4qHsrs/TsG5wh02RNIk3ypDVmyrBygMMt8hyoqtHOkkpDn/fzmWcuLHGZ0vdaQ0Z8F4zvoBuRh5PABrtVma6vEjTbeWOHSwx+uNSiX8hdrXMjLP+Gk5ypAqDArNxCFdPW9xcZVd68Ie93VE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P+UMzxCs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P+UMzxCs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708339640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ko3bpSB6LFYSpgZ7lp23nszsYntVgh+j/LkPwXE8CwA=; b=P+UMzxCsV1sVBrIdUDg/gMiseEeZrTGdJOL65pulF4edLcDBiywltTFHBJqgC/3+ISBm5B YLLH3j6iq1L+jbM8O7bF5CEVAzEKkk6pAmC3BMmZRf5zEi5KjKUtNz3wyUuFBnQ1DZXQKi w2EKyPGzPKp5BrG8D7g0WLxMdu/cR0I= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-nuJKc3-eO8uU9PZxXRq26Q-1; Mon, 19 Feb 2024 05:47:19 -0500 X-MC-Unique: nuJKc3-eO8uU9PZxXRq26Q-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5117210e716so3377635e87.2 for ; Mon, 19 Feb 2024 02:47:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708339637; x=1708944437; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ko3bpSB6LFYSpgZ7lp23nszsYntVgh+j/LkPwXE8CwA=; b=NjzcSaJHFFhOpkj4RfBdH8fXxAXPuW1HM/5KkdHZkP7sONJVUOt6rE08lMnv9LJo8j dsX009YWkzQwYAO6cJuBvo7gMP6wURW1/dKztBo6KW4In4yD/K7FuDmvYA9qX6J5nyY4 ZsPtnAlXlleA0s/uz4sckj5QXrzb3ITEh1G9vTUJclyIlxLGM0tr/6TNJQQxoy27h00Y pcxl8LhaG4pbCKIDOjlstoGV6hWYX4/O8ihCS8dyYh+vKGQZVVyQN90kWD9dydrxz/OV Lgtxlh0lP0FZozyr2NvtZarrCnudad6CtSW1IJ5ttTOgC3NOmiK0abNLZea5q53XoM3Z m0OQ== X-Forwarded-Encrypted: i=1; AJvYcCVOym00llOqQ9/lAdxk4GqzPrucfglTk5gAXbYtvyALSge0J0ixu1NnYFZY0f1WF9td8CGrB9Dq6onRzf7CoVyRYsgsxhnEsOEUSUg= X-Gm-Message-State: AOJu0YzI3SKKRFnj+JMqjsL+IdX3ib84lCcyyd/O9UENbL9IwMYZo4Hc MFNXT4QbjWpGhq6SRie0xHRzVsL3ENY5aOrZE3dDESVw9Wg+IqCgW1t9lRR/JhaB8nhtMlqtpKq A6UVMIgPpFOtQSVrZ43lRvOnGSioMvtiJq/cobsYLsEX0F+WjEHmG1UurvfnvF+fjfuiy X-Received: by 2002:a2e:8085:0:b0:2d0:c396:f5b2 with SMTP id i5-20020a2e8085000000b002d0c396f5b2mr7365312ljg.27.1708339637621; Mon, 19 Feb 2024 02:47:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHGhWKUj8jz9hZvXJzX/Lii21jxx3r1v/utV+TrgxtPsn0JzFtwNZxLPfJJLOPwMCNsgx6o/g== X-Received: by 2002:a2e:8085:0:b0:2d0:c396:f5b2 with SMTP id i5-20020a2e8085000000b002d0c396f5b2mr7365295ljg.27.1708339637230; Mon, 19 Feb 2024 02:47:17 -0800 (PST) Received: from redhat.com ([2.52.19.211]) by smtp.gmail.com with ESMTPSA id p6-20020adfe606000000b0033cdbe335bcsm10016533wrm.71.2024.02.19.02.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 02:47:16 -0800 (PST) Date: Mon, 19 Feb 2024 05:47:13 -0500 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Ming Lei , "jasowang@redhat.com" , "xuanzhuo@linux.alibaba.com" , "pbonzini@redhat.com" , "stefanha@redhat.com" , "axboe@kernel.dk" , "virtualization@lists.linux.dev" , "linux-block@vger.kernel.org" , "stable@vger.kernel.org" , "NBU-Contact-Li Rongqing (EXTERNAL)" , Chaitanya Kulkarni Subject: Re: [PATCH] virtio_blk: Fix device surprise removal Message-ID: <20240219054459-mutt-send-email-mst@kernel.org> References: <20240217180848.241068-1-parav@nvidia.com> <20240219024301-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Feb 19, 2024 at 10:39:36AM +0000, Parav Pandit wrote: > > From: Michael S. Tsirkin > > Sent: Monday, February 19, 2024 1:45 PM > > > > On Mon, Feb 19, 2024 at 03:14:54AM +0000, Parav Pandit wrote: > > > Hi Ming, > > > > > > > From: Ming Lei > > > > Sent: Sunday, February 18, 2024 6:57 PM > > > > > > > > On Sat, Feb 17, 2024 at 08:08:48PM +0200, Parav Pandit wrote: > > > > > When the PCI device is surprise removed, requests won't complete > > > > > from the device. These IOs are never completed and disk deletion > > > > > hangs indefinitely. > > > > > > > > > > Fix it by aborting the IOs which the device will never complete > > > > > when the VQ is broken. > > > > > > > > > > With this fix now fio completes swiftly. > > > > > An alternative of IO timeout has been considered, however when the > > > > > driver knows about unresponsive block device, swiftly clearing > > > > > them enables users and upper layers to react quickly. > > > > > > > > > > Verified with multiple device unplug cycles with pending IOs in > > > > > virtio used ring and some pending with device. > > > > > > > > > > In future instead of VQ broken, a more elegant method can be used. > > > > > At the moment the patch is kept to its minimal changes given its > > > > > urgency to fix broken kernels. > > > > > > > > > > Fixes: 43bb40c5b926 ("virtio_pci: Support surprise removal of > > > > > virtio pci device") > > > > > Cc: stable@vger.kernel.org > > > > > Reported-by: lirongqing@baidu.com > > > > > Closes: > > > > > https://lore.kernel.org/virtualization/c45dd68698cd47238c55fb73ca9 > > > > > b474 > > > > > 1@baidu.com/ > > > > > Co-developed-by: Chaitanya Kulkarni > > > > > Signed-off-by: Chaitanya Kulkarni > > > > > Signed-off-by: Parav Pandit > > > > > --- > > > > > drivers/block/virtio_blk.c | 54 > > > > > ++++++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 54 insertions(+) > > > > > > > > > > diff --git a/drivers/block/virtio_blk.c > > > > > b/drivers/block/virtio_blk.c index 2bf14a0e2815..59b49899b229 > > > > > 100644 > > > > > --- a/drivers/block/virtio_blk.c > > > > > +++ b/drivers/block/virtio_blk.c > > > > > @@ -1562,10 +1562,64 @@ static int virtblk_probe(struct > > > > > virtio_device > > > > *vdev) > > > > > return err; > > > > > } > > > > > > > > > > +static bool virtblk_cancel_request(struct request *rq, void *data) { > > > > > + struct virtblk_req *vbr = blk_mq_rq_to_pdu(rq); > > > > > + > > > > > + vbr->in_hdr.status = VIRTIO_BLK_S_IOERR; > > > > > + if (blk_mq_request_started(rq) && !blk_mq_request_completed(rq)) > > > > > + blk_mq_complete_request(rq); > > > > > + > > > > > + return true; > > > > > +} > > > > > + > > > > > +static void virtblk_cleanup_reqs(struct virtio_blk *vblk) { > > > > > + struct virtio_blk_vq *blk_vq; > > > > > + struct request_queue *q; > > > > > + struct virtqueue *vq; > > > > > + unsigned long flags; > > > > > + int i; > > > > > + > > > > > + vq = vblk->vqs[0].vq; > > > > > + if (!virtqueue_is_broken(vq)) > > > > > + return; > > > > > + > > > > > > > > What if the surprise happens after the above check? > > > > > > > > > > > In that small timing window, the race still exists. > > > > > > I think, blk_mq_quiesce_queue(q); should move up before cleanup_reqs() > > regardless of surprise case along with other below changes. > > > > > > Additionally, for non-surprise case, better to have a graceful timeout to > > complete already queued requests. > > > In absence of timeout scheme for this regression, shall we only complete the > > requests which the device has already completed (instead of waiting for the > > grace time)? > > > There was past work from Chaitanaya, for the graceful timeout. > > > > > > The sequence for the fix I have in mind is: > > > 1. quiesce the queue > > > 2. complete all requests which has completed, with its status 3. stop > > > the transport (queues) 4. complete remaining pending requests with > > > error status > > > > > > This should work regardless of surprise case. > > > An additional/optional graceful timeout on non-surprise case can be helpful > > for #2. > > > > > > WDYT? > > > > All this is unnecessarily hard for drivers... I am thinking maybe after we set > > broken we should go ahead and invoke all callbacks. > > Yes, #2 is about invoking the callbacks. > > The issue is not with setting the flag broken. As Ming pointed, the issue is : we may miss setting the broken. So if we did get callbacks, we'd be able to test broken flag in the callback. > Without graceful time out it is straight forward code, just rearrangement of APIs in this patch with existing code. > > The question is : it is really if we really care for that grace period when the device or driver is already on its exit path and VQ is not broken. > If we don't wait for the request in progress, is it ok? > If we are talking about physical hardware, it seems quite possible that removal triggers then user gets impatient and yanks the card out. > > interrupt handling core is not making it easy for us - we must disable real > > interrupts if we do, and in the past we failed to do it. > > See e.g. > > > > > > commit eb4cecb453a19b34d5454b49532e09e9cb0c1529 > > Author: Jason Wang > > Date: Wed Mar 23 11:15:24 2022 +0800 > > > > Revert "virtio_pci: harden MSI-X interrupts" > > > > This reverts commit 9e35276a5344f74d4a3600fc4100b3dd251d5c56. > > Issue > > were reported for the drivers that are using affinity managed IRQ > > where manually toggling IRQ status is not expected. And we forget to > > enable the interrupts in the restore path as well. > > > > In the future, we will rework on the interrupt hardening. > > > > Fixes: 9e35276a5344 ("virtio_pci: harden MSI-X interrupts") > > > > > > > > If someone can figure out a way to make toggling interrupt state play nice with > > affinity managed interrupts, that would solve a host of issues I feel. > > > > > > > > > > Thanks, > > > > Ming