From: Eric Biggers <ebiggers@kernel.org>
To: Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
steve.kang@unisoc.com
Subject: Re: [Resend PATCHv9 1/1] block: introduce content activity based ioprio
Date: Tue, 20 Feb 2024 21:52:56 -0800 [thread overview]
Message-ID: <20240221055256.GB14358@sol.localdomain> (raw)
In-Reply-To: <CAGWkznHTY-ROF-D2w8BjGabfzw1yAqoGsHz321BUKrRBcWuqaw@mail.gmail.com>
On Wed, Feb 21, 2024 at 01:50:55PM +0800, Zhaoyang Huang wrote:
> On Wed, Feb 21, 2024 at 1:41 PM Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > On Wed, Feb 21, 2024 at 01:26:24PM +0800, zhaoyang.huang wrote:
> > > +/*
> > > + * bio_set_active_ioprio_folio is helper function to count the bio's
> > > + * content's activities which measured by MGLRU.
> > > + * The file system should call this function after bio_add_page/folio for
> > > + * the buffered read/write/sync.
> > > + */
> > > +#ifdef CONFIG_BLK_CONT_ACT_BASED_IOPRIO
> > > +void bio_set_active_ioprio_folio(struct bio *bio, struct folio *folio)
> >
> > How did you test this? Nothing calls this function, so this patch can't
> > actually be doing anything. Are you planning to update any filesystems to use
> > this?
> Thanks for asking. I verified this patch in an Android based 6GB RAM
> system by modifying EROFS/F2FS/EXT4's aops API which I didn't
> upstreaming yet. I would like to recommend this to the desired fs if
> this is accepted.
This patch needs to come with a user. Unused code can't be accepted.
- Eric
prev parent reply other threads:[~2024-02-21 5:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 5:26 [Resend PATCHv9 1/1] block: introduce content activity based ioprio zhaoyang.huang
2024-02-21 5:41 ` Eric Biggers
2024-02-21 5:50 ` Zhaoyang Huang
2024-02-21 5:52 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221055256.GB14358@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=axboe@kernel.dk \
--cc=huangzhaoyang@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steve.kang@unisoc.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox