From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Wen Xiong <wenxiong@us.ibm.com>
Subject: Re: [PATCH] blk-mq: don't change nr_hw_queues and nr_maps for kdump kernel
Date: Wed, 28 Feb 2024 14:24:11 +0100 [thread overview]
Message-ID: <20240228132411.GA11497@lst.de> (raw)
In-Reply-To: <20240228040857.306483-1-ming.lei@redhat.com>
On Wed, Feb 28, 2024 at 12:08:57PM +0800, Ming Lei wrote:
> For most of ARCHs, 'nr_cpus=1' is passed for kdump kernel, so
> nr_hw_queues for each mapping is supposed to be 1 already.
>
> More importantly, this way may cause trouble for driver, because blk-mq and
> driver see different queue mapping since driver should setup hardware
> queue setting before calling into allocating blk-mq tagset.
>
> So not overriding nr_hw_queues and nr_maps for kdump kernel.
Great to see this hack retired.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-02-28 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 4:08 [PATCH] blk-mq: don't change nr_hw_queues and nr_maps for kdump kernel Ming Lei
2024-02-28 13:24 ` Christoph Hellwig [this message]
2024-02-28 14:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228132411.GA11497@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox