From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
Lennart Poettering <mzxreary@0pointer.de>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] block: add a partscan sysfs attribute for disks
Date: Fri, 3 May 2024 10:16:12 +0200 [thread overview]
Message-ID: <20240503081612.GA24407@lst.de> (raw)
In-Reply-To: <6e70dd3f-381c-4435-a523-588ce2fafb39@kernel.dk>
On Thu, May 02, 2024 at 11:05:54AM -0600, Jens Axboe wrote:
> On 5/2/24 7:00 AM, Christoph Hellwig wrote:
> > This attribute reports if partition scanning is enabled for a given disk.
>
> This should, at least, have a reference to Lennart's posting, and
> honestly a much better commit message as well. There's no reasoning
> given here at all.
I'm not sure I can come up with something much better, feel free to
throw in what you prefer.
> Maybe even a fixes tag and stable notation?
This is definitively not a Fixes as nothing it doesn't actually fix
any code. It provides a proper interfaces for what was an abuse
of leaking internal bits out.
next prev parent reply other threads:[~2024-05-03 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 13:00 add a partscan sysfs attribute v2 Christoph Hellwig
2024-05-02 13:00 ` [PATCH 1/2] block: add a disk_has_partscan helper Christoph Hellwig
2024-05-02 13:00 ` [PATCH 2/2] block: add a partscan sysfs attribute for disks Christoph Hellwig
2024-05-02 17:05 ` Jens Axboe
2024-05-03 8:16 ` Christoph Hellwig [this message]
2024-05-03 9:12 ` Keith Busch
2024-05-03 14:59 ` Jens Axboe
2024-05-03 14:57 ` Jens Axboe
2024-05-03 15:01 ` add a partscan sysfs attribute v2 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2024-04-29 17:48 add a partscan sysfs attribute Christoph Hellwig
2024-04-29 17:49 ` [PATCH 2/2] block: add a partscan sysfs attribute for disks Christoph Hellwig
2024-04-30 14:10 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240503081612.GA24407@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=mzxreary@0pointer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox