From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5852013CABB for ; Thu, 23 May 2024 07:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716448745; cv=none; b=SWYKIvKuJGXL7wRk94qy3icCxaYb0LaSKaeejgaIy8u8xSXZpGXVyf3WQKNT4V86EAuAl7qSjQqaOGJiShbMHlSrTlKqP6ZOvoOoamf489FrJB3RYR9o8xaHmqprLdByCBCPCVaU70xbMmg5eNUZuvC3Osx4Nn5PBqiaJms/7jg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716448745; c=relaxed/simple; bh=bCWU7Lc3U6Gf5GeFq7c4kfDiTYQheurIl1SgCCmRW2E=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:In-Reply-To: Content-Type:References; b=bHtf+ES2AcYy8ijX70K5ETq+89f9rQ41MftfoC1KHycHqp7sxBM7nG1s6Upxmx8k5AX+FD2EEmX+EZn8NkpCLEQrRGQlW9Jgfl/s9QZ/sSTHEO+Ie+oC61OK5MbNv6jb2SyrSMe+9eXvCCc1H71VoB72GTwsyJk6jE0NUFjTrIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=Tf7+WlgL; arc=none smtp.client-ip=203.254.224.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="Tf7+WlgL" Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20240523071856epoutp02cea3ff2f3323ac7354294e9fedf4fb23~SDQgPcW_N2723927239epoutp021 for ; Thu, 23 May 2024 07:18:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20240523071856epoutp02cea3ff2f3323ac7354294e9fedf4fb23~SDQgPcW_N2723927239epoutp021 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1716448736; bh=bCWU7Lc3U6Gf5GeFq7c4kfDiTYQheurIl1SgCCmRW2E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Tf7+WlgLBawm/YVOH/7VyF+LvicAHD0h0EumnzsVsMKnmsCiKN2AkWy84PN9iJnKp +RebvJV1T9GTPfAAmOZu4LW9sRvt0qIW48Lviixv5JtcgHibp4Uio+HXD9yWoCQMMo LVATUhIpbuu6Zu2t+8LNCan3lF+j5b5MGS0tNRlU= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas5p2.samsung.com (KnoxPortal) with ESMTP id 20240523071855epcas5p21aeec08c159e8d0f1adcdf6b64938e3f~SDQfodwgx1031010310epcas5p29; Thu, 23 May 2024 07:18:55 +0000 (GMT) Received: from epsmges5p1new.samsung.com (unknown [182.195.38.180]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4VlKKV11Gxz4x9Q5; Thu, 23 May 2024 07:18:54 +0000 (GMT) Received: from epcas5p4.samsung.com ( [182.195.41.42]) by epsmges5p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 18.17.09666.DDDEE466; Thu, 23 May 2024 16:18:54 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas5p2.samsung.com (KnoxPortal) with ESMTPA id 20240523071219epcas5p2e8a92db80cd848b52d49715b1c010006~SDKu17ZOh2481924819epcas5p2x; Thu, 23 May 2024 07:12:19 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240523071219epsmtrp21c79b655e9d0043b667ac9556b156183~SDKu0vTEG1280012800epsmtrp2G; Thu, 23 May 2024 07:12:19 +0000 (GMT) X-AuditID: b6c32a49-f53fa700000025c2-ba-664eedddf85d Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 45.46.08924.35CEE466; Thu, 23 May 2024 16:12:19 +0900 (KST) Received: from nj.shetty?samsung.com (unknown [107.99.41.245]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20240523071215epsmtip14cb2b6df4b2fd21744f10ec306679a1d~SDKrOsSq10670606706epsmtip1T; Thu, 23 May 2024 07:12:15 +0000 (GMT) Date: Thu, 23 May 2024 07:05:12 +0000 From: Nitesh Shetty To: Bart Van Assche Cc: Jens Axboe , Jonathan Corbet , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Keith Busch , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Alexander Viro , Christian Brauner , Jan Kara , martin.petersen@oracle.com, david@fromorbit.com, hare@suse.de, damien.lemoal@opensource.wdc.com, anuj20.g@samsung.com, joshi.k@samsung.com, nitheshshetty@gmail.com, gost.dev@samsung.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dm-devel@lists.linux.dev, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v20 01/12] block: Introduce queue limits and sysfs for copy-offload support Message-ID: <20240523070512.kku7gtw5qanmsrjg@nj.shetty@samsung.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <174d4908-b81c-4775-9b99-b0941451cb0e@acm.org> X-Brightmail-Tracker: H4sIAAAAAAAAA02TezBcdxTH+7t39+6lo9kSyS9LRLbTNKTYTdAfsdIJ096OtEw7bVKZdm3s DYLdzT5KHjPWK8I0IkLMIi1qyKII247XtrKK0Kh0kJQpMkGnRdhEPFpFl0sn/33O95zvnPM7 Z34kblvP4ZFRMjWtlEli+IQ16/s2F1e3kScfnBZktOKoprsDR0lZKziqHL5KoKm2ZwDdMP+N o/HWNICWe3pxZOgYAaio5CYLDbY2YqilJBtD+sp2DBXkJWOofe0JgbJNDwCaGMjHkHHoACq+ VMpCLcYuFuprKiTQ12UTHFTeuYqha5cHMNQwnghQ9dQsC90dckC9K53stx2ovv4gqrsEUo35 wxyqd+Q2i+rr0VB1FekEVV+aQP1ZrwNU86CWoL7JvM6mriTPEFRj6iibejoxxKJmfxggqExD BaDuFf3ECbELjfaLpCVSWulMy8Ll0ihZhIgf9JE4QOzlLRC6CX3QW3xnmSSWFvEDj4W4vRMV Y1kO3/kLSYzGIoVIVCq+h7+fUq5R086RcpVaxKcV0hiFp8JdJYlVaWQR7jJa7SsUCA56WQrD oiO1aX6K+1bxl2r7MS3QkRnAioRcT9j+eIyVAaxJW24zgJXfjhFM8AxAbfFlNhMsAFh2/yF7 y1J1p23TYgTQmNnFYYI5S9W0jlivYnFfh0uGcQuTJME9AH9e2+i3nbsfLjwq3zDj3GIC/v7b Er6esONKYPmgEayzDTcA9k2ucBh+FXbpxlnrbMU9DKtzKsG6GXIfW8F/ZtY4zEiBsCknhWDY Dk52GjZ1HpybMW7qcVCfc4tgzCkA5j/MB0ziCEztvroxBc6NhObpUpzRd8Pc7mqM0V+BV5bH MUa3gQ1fbfFrsKqmaLPBLvhgMXGTKVgw0YYxa7mHwdxf04ks4JT/wovyX+jHsC9MNyexGd4D k78rsOikhR1g+SrJoAusafIoAkQF2EUrVLERtMpLIZTRcf+fPFweWwc2fo/rew1g+JHZ3QQw EpgAJHH+dpuT+vdP29pIJefO00q5WKmJoVUm4GW51jWcZx8ut3w/mVos9PQReHp7e3v6HPIW 8nfaTKXelNpyIyRqOpqmFbRyy4eRVjwt5j8Y6lRd/lwT/HLyHm1hcp3RftJV3KfyiIclea6+ d07u6DWHib60EtWrO2suOn4cP1W67XZz8DTreVz2ioveJ7bHPNaXYHpz22ghWebEu6Wyzuw/ rDuR4BBqeKlg92rm2bN69qnPOcNuT/WJe/eFHSMzSlp+6aqN/XHcb3X+jL5n1NCY9Eb6DX9B 3l+IPW+vCb4benRHV1Xg8v4jw4txF5onPgk8/wc4Xh8QdOK6QfrZh4lFS/OH3l0kNAOST2vM sIV3efb4mRQdXeeoa3YR4mmFeRPTWQu6HPe8Wrf+C+dE7AXfU3Le2EXhQb6jjs0XJE3Z7mWn mP6dE+/cF7jYkTvCZ6kiJUJXXKmS/AeyGZ60xgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42LZdlhJTjf4jV+awcF7UhbrTx1jtmia8JfZ YvXdfjaL14c/MVpM+/CT2eLJgXZGi99nzzNbbDl2j9FiwaK5LBY3D+xkstizaBKTxcrVR5ks Zk9vZrI4+v8tm8WkQ9cYLZ5encVksfeWtsXCtiUsFnv2nmSxuLxrDpvF/GVP2S2WH//HZDGx 4yqTxY4njYwW616/Z7E4cUva4vzf46wO0h6Xr3h7nFok4bFz1l12j/P3NrJ4XD5b6rFpVSeb x+Yl9R4vNs9k9Nh9s4HNY3HfZFaP3uZ3bB47W++zenx8eovF4/2+q2wefVtWMXqcWXCEPUA4 issmJTUnsyy1SN8ugSvj6Pn9zAUP2SreXtrI3sB4nLWLkZNDQsBEYs3BwyxdjFwcQgK7GSVu PPrBBJGQlFj29wgzhC0ssfLfc3aIoo+MEv1z14IlWARUJX5secLWxcjBwSagLXH6PwdIWERA Q+Lbg+VgQ5kFlrJJXNz/mx0kISyQKLH85l5GEJtXwFni8qu/UEPPMEkcv9fDDJEQlDg58wkL iM0sYCYxb/NDZpAFzALSEsv/cUCE5SWat84GK+cUsJZYN2U14wRGwVlIumch6Z6F0D0LSfcC RpZVjJKpBcW56bnFhgWGeanlesWJucWleel6yfm5mxjBiURLcwfj9lUf9A4xMnEwHmKU4GBW EuGNXumbJsSbklhZlVqUH19UmpNafIhRmoNFSZxX/EVvipBAemJJanZqakFqEUyWiYNTqoGJ 12jVtS5O83NXWjMCK4OfL/jV1f7rstbeyCmnPonvWNboZ7OCO/Nlp4v557eCcyZr7NV64t/i fuc/U752aQ/n0z6Dcxc6ttftKr9/VK+bXX/+Bk9pRvc5MZHTK/RsM9mVGd5uWsQW8yPs0xeH i08DTxl/OLWrcuOLLPGdWveWc4idWL46yeGO7mHHvPlRps3O658wqt04l9e3/94+tfp4ywOt rRPWft69+/HVyh2uv8Q2cjOvsP+ecEDKlH9ZulnstL1V0U71Qpt/lcVfq2afZvabebITf1SG v57o9YjKzIq4HbVnamL2G39wKWt8pRI882vndZ73+xd8kYh6fVj2p7rLf+2ezl0tny38tiso sRRnJBpqMRcVJwIAAu4TPpMDAAA= X-CMS-MailID: 20240523071219epcas5p2e8a92db80cd848b52d49715b1c010006 X-Msg-Generator: CA Content-Type: multipart/mixed; boundary="----Fualeei1.f5fhWGYL679EBd0hH5-OLgtfrOtH6wInDZGwDEe=_1f672_" X-Sendblock-Type: REQ_APPROVE CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20240520102830epcas5p27274901f3d0c2738c515709890b1dec4 References: <20240520102033.9361-1-nj.shetty@samsung.com> <20240520102033.9361-2-nj.shetty@samsung.com> <20240521142509.o7fu7gpxcvsrviav@green245> <174d4908-b81c-4775-9b99-b0941451cb0e@acm.org> ------Fualeei1.f5fhWGYL679EBd0hH5-OLgtfrOtH6wInDZGwDEe=_1f672_ Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Disposition: inline On 22/05/24 10:49AM, Bart Van Assche wrote: >On 5/21/24 07:25, Nitesh Shetty wrote: >>On 20/05/24 03:42PM, Bart Van Assche wrote: >>>On 5/20/24 03:20, Nitesh Shetty wrote: >>>>+    if (max_copy_bytes & (queue_logical_block_size(q) - 1)) >>>>+        return -EINVAL; >>> >>>Wouldn't it be more user-friendly if this check would be left out? Does any code >>>depend on max_copy_bytes being a multiple of the logical block size? >>> >>In block layer, we use max_copy_bytes to split larger copy into >>device supported copy size. >>Simple copy spec requires length to be logical block size aligned. >>Hence this check. > >Will blkdev_copy_sanity_check() reject invalid copy requests even if this >check is left out? > Yes, you are right. We have checks both places. We will remove checks in one of the places. Thank you, Nitesh Shetty ------Fualeei1.f5fhWGYL679EBd0hH5-OLgtfrOtH6wInDZGwDEe=_1f672_ Content-Type: text/plain; charset="utf-8" ------Fualeei1.f5fhWGYL679EBd0hH5-OLgtfrOtH6wInDZGwDEe=_1f672_--