From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Benjamin Marzinski <bmarzins@redhat.com>
Subject: Re: [PATCH v3 2/2] dm: Improve zone resource limits handling
Date: Wed, 5 Jun 2024 08:49:10 +0200 [thread overview]
Message-ID: <20240605064910.GB14642@lst.de> (raw)
In-Reply-To: <20240605063907.129120-3-dlemoal@kernel.org>
> + /*
> + * If the limits are larger than the number of mapped sequential zones,
> + * assume no limits. Note that blk_revalidate_disk_zones() also executes
> + * this adjustment, but only for mapped devices that use zone write
> + * plugging, that is, for mapped devices needing zone append emulation.
> + * So for DM devices using native zone append of the target devices, we
> + * need to adjust the zone resource limits here.
> + */
> + if (lim->max_active_zones > zlim.mapped_nr_seq_zones)
> + lim->max_active_zones = 0;
> + if (lim->max_open_zones > zlim.mapped_nr_seq_zones)
> + lim->max_open_zones = 0;
Is there any good reason to not just do this unconditionally in common
code?
next prev parent reply other threads:[~2024-06-05 6:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 6:39 [PATCH v3 0/2] Fix DM zone resource limits stacking Damien Le Moal
2024-06-05 6:39 ` [PATCH v3 1/2] block: Imporve checks on zone resource limits Damien Le Moal
2024-06-05 6:45 ` Christoph Hellwig
2024-06-05 6:46 ` Damien Le Moal
2024-06-05 6:39 ` [PATCH v3 2/2] dm: Improve zone resource limits handling Damien Le Moal
2024-06-05 6:49 ` Christoph Hellwig [this message]
2024-06-05 6:55 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605064910.GB14642@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bmarzins@redhat.com \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox