From: Christoph Hellwig <hch@lst.de>
To: Chengming Zhou <chengming.zhou@linux.dev>
Cc: Friedrich Weber <f.weber@proxmox.com>,
axboe@kernel.dk, ming.lei@redhat.com, hch@lst.de,
bvanassche@acm.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, zhouchengming@bytedance.com,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [PATCH] block: fix request.queuelist usage in flush
Date: Fri, 7 Jun 2024 06:55:11 +0200 [thread overview]
Message-ID: <20240607045511.GB2857@lst.de> (raw)
In-Reply-To: <dea87c0a-1c36-4737-bea5-cb7fa273b724@linux.dev>
On Fri, Jun 07, 2024 at 10:37:58AM +0800, Chengming Zhou wrote:
> Yeah, right, it seems LVM may create this special request that only has
> PREFLUSH | POSTFLUSH without any DATA, goes into the flush state machine.
> Then, cause the request double list_add_tail() without list_del_init().
> I don't know the reason behind it, but well, it's allowable in the current
> flush code.
PREFLUSH | POSTFLUSH is a weird invalid format. We'll need to fix this
in dm, and probably also catch it in the block layer submission path.
next prev parent reply other threads:[~2024-06-07 4:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 6:47 [PATCH] block: fix request.queuelist usage in flush Chengming Zhou
2024-06-04 14:17 ` Jens Axboe
2024-06-05 18:14 ` Jens Axboe
2024-06-05 8:45 ` Friedrich Weber
2024-06-05 10:30 ` Chengming Zhou
2024-06-05 10:54 ` Friedrich Weber
2024-06-05 13:34 ` Friedrich Weber
2024-06-05 14:27 ` Chengming Zhou
2024-06-06 8:44 ` Friedrich Weber
2024-06-06 16:05 ` Friedrich Weber
2024-06-07 2:37 ` Chengming Zhou
2024-06-07 4:55 ` Christoph Hellwig [this message]
2024-06-07 6:24 ` Chengming Zhou
2024-06-07 6:31 ` Christoph Hellwig
2024-06-07 6:33 ` Chengming Zhou
2024-06-07 15:13 ` Friedrich Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607045511.GB2857@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chengming.zhou@linux.dev \
--cc=f.weber@proxmox.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=t.lamprecht@proxmox.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox