From: Greg KH <gregkh@linuxfoundation.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, tj@kernel.org, josef@toxicpanda.com,
lizefan.x@bytedance.com, hannes@cmpxchg.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com,
yangerkun@huawei.com
Subject: Re: [PATCH RFC -next 1/7] kernfs: export pr_cont_kernfs_path()
Date: Thu, 13 Jun 2024 07:55:51 +0200 [thread overview]
Message-ID: <2024061314-moodiness-snowflake-14c5@gregkh> (raw)
In-Reply-To: <20240613014937.1326020-2-yukuai1@huaweicloud.com>
On Thu, Jun 13, 2024 at 09:49:31AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> This helper is used in iocost, prepare to build iocost as kernel module.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> fs/kernfs/dir.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
> index 458519e416fe..84ad163a4281 100644
> --- a/fs/kernfs/dir.c
> +++ b/fs/kernfs/dir.c
> @@ -279,6 +279,7 @@ void pr_cont_kernfs_path(struct kernfs_node *kn)
> out:
> spin_unlock_irqrestore(&kernfs_pr_cont_lock, flags);
> }
> +EXPORT_SYMBOL_GPL(pr_cont_kernfs_path);
This isn't the helper that needs to be exported, it's a include wrapper
that is using this for cgroups. Please document this much better and
perhaps, just fix up the cgroups code instead?
thanks,
greg k-h
next prev parent reply other threads:[~2024-06-13 5:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 1:49 [PATCH RFC -next 0/7] blk-iocost: support to build iocost as kernel module Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 1/7] kernfs: export pr_cont_kernfs_path() Yu Kuai
2024-06-13 5:55 ` Greg KH [this message]
2024-06-13 6:55 ` Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 2/7] cgroup: export cgroup_parse_float Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 3/7] block: export some API Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 4/7] blk-iocost: factor out helpers to handle params from ioc_qos_write() Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 5/7] blk-iocost: parse params before initializing iocost Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 6/7] blk-iocost: support to free iocost Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 7/7] blk-iocost: support to build iocost as kernel module Yu Kuai
2024-06-13 5:54 ` Greg KH
2024-06-13 5:54 ` [PATCH RFC -next 0/7] " Greg KH
2024-06-13 6:53 ` Yu Kuai
2024-06-13 16:15 ` Bart Van Assche
2024-06-14 1:07 ` Yu Kuai
2024-06-14 5:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024061314-moodiness-snowflake-14c5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).