From: Christoph Hellwig <hch@lst.de>
To: Gulam Mohamed <gulam.mohamed@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yukuai1@huaweicloud.com" <yukuai1@huaweicloud.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH V6 for-6.11/block] loop: Fix a race between loop detach and loop open
Date: Wed, 19 Jun 2024 10:27:18 +0200 [thread overview]
Message-ID: <20240619082718.GA6210@lst.de> (raw)
In-Reply-To: <IA1PR10MB7240896628D86A86E91DE9E798CF2@IA1PR10MB7240.namprd10.prod.outlook.com>
On Wed, Jun 19, 2024 at 08:21:35AM +0000, Gulam Mohamed wrote:
> > To: Gulam Mohamed <gulam.mohamed@oracle.com>
> > Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org;
> > yukuai1@huaweicloud.com; hch@lst.de; axboe@kernel.dk
> > Subject: Re: [PATCH V6 for-6.11/block] loop: Fix a race between loop detach
> > and loop open
> >
> > Do we need the re-addition of the open method to fix the ltp test case? I
> > kinda hate it, but if that is what it takes:
> >
> I don't think its needed but I kept it because your following comment in the suggested change says " switch the state to roundown here to prevent new openers from coming in":
Let's keep it. I meant to say new I/O coming in, but letting a new
opener come in and then fail I/O isn't really nice behavior.
next prev parent reply other threads:[~2024-06-19 8:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 16:40 [PATCH V6 for-6.11/block] loop: Fix a race between loop detach and loop open Gulam Mohamed
2024-06-19 8:16 ` Christoph Hellwig
2024-06-19 8:21 ` Gulam Mohamed
2024-06-19 8:27 ` Christoph Hellwig [this message]
2024-06-19 9:00 ` Gulam Mohamed
2024-06-27 20:13 ` Gulam Mohamed
2024-06-27 22:11 ` Jens Axboe
2024-06-28 9:25 ` Gulam Mohamed
2024-06-27 22:11 ` Jens Axboe
2024-06-28 5:39 ` kernel test robot
2024-06-30 22:11 ` Gulam Mohamed
2024-07-02 15:50 ` hch
2024-07-05 19:51 ` Gulam Mohamed
2024-07-09 9:09 ` Gulam Mohamed
2024-07-09 11:21 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619082718.GA6210@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gulam.mohamed@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox