From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 5/5] block: remove bio_integrity_process
Date: Thu, 27 Jun 2024 17:47:59 +0200 [thread overview]
Message-ID: <20240627154759.GA25261@lst.de> (raw)
In-Reply-To: <a7fd0e31-63bd-8fff-d7d4-6ba990098e7a@samsung.com>
On Thu, Jun 27, 2024 at 09:06:56PM +0530, Kanchan Joshi wrote:
> The bi->csum_type is constant as far as this bio_for_each_segment loop
> is concerned.
> Seems wasteful processing, and can rather be moved out where we set a
> function pointer to point to either ext_pi_crc64_generate or
> t10_pi_generate once.
A function pointer is way more expensive than a few branches, especially
easily predictable ones.
next prev parent reply other threads:[~2024-06-27 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 4:59 integrity cleanups Christoph Hellwig
2024-06-26 4:59 ` [PATCH 1/5] block: only zero non-PI metadata tuples in bio_integrity_prep Christoph Hellwig
2024-06-27 15:42 ` Kanchan Joshi
2024-06-26 4:59 ` [PATCH 2/5] block: simplify adding the payload " Christoph Hellwig
2024-06-27 15:42 ` Kanchan Joshi
2024-06-26 4:59 ` [PATCH 3/5] block: remove allocation failure warnings " Christoph Hellwig
2024-06-27 15:42 ` Kanchan Joshi
2024-06-26 4:59 ` [PATCH 4/5] block: switch on bio operation " Christoph Hellwig
2024-06-27 15:41 ` Kanchan Joshi
2024-06-26 4:59 ` [PATCH 5/5] block: remove bio_integrity_process Christoph Hellwig
2024-06-27 15:36 ` Kanchan Joshi
2024-06-27 15:47 ` Christoph Hellwig [this message]
2024-06-27 18:33 ` Kanchan Joshi
2024-06-28 6:02 ` Christoph Hellwig
2024-06-27 3:44 ` integrity cleanups Martin K. Petersen
2024-06-28 16:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627154759.GA25261@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox