Linux block layer
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org
Subject: Re: [PATCH 09/11] block: Make RQF_x as an enum
Date: Tue, 9 Jul 2024 13:23:18 +0200	[thread overview]
Message-ID: <20240709112318.GA5358@lst.de> (raw)
In-Reply-To: <20240709110538.532896-10-john.g.garry@oracle.com>

> +enum {
> +	/* drive already may have started this one */
> +	RQF_STARTED		=	((__force req_flags_t)(1 << 0)),

Last time I tried to mix __bitwise and enums sparse was very unhappy.
Did this get fixed?


  reply	other threads:[~2024-07-09 11:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 11:05 [PATCH RFC 00/11] block debugfs: Catch missing flag array members John Garry
2024-07-09 11:05 ` [PATCH 01/11] block: remove QUEUE_FLAG_STOPPED John Garry
2024-07-09 11:05 ` [PATCH 02/11] block: Make QUEUE_FLAG_x as an enum John Garry
2024-07-09 11:05 ` [PATCH 03/11] block: Add build-time assert for size of blk_queue_flag_name[] John Garry
2024-07-09 11:05 ` [PATCH 04/11] block: Catch possible entries missing from hctx_state_name[] John Garry
2024-07-09 11:05 ` [PATCH 05/11] block: Catch possible entries missing from hctx_flag_name[] John Garry
2024-07-09 11:05 ` [PATCH 06/11] block: Catch possible entries missing from alloc_policy_name[] John Garry
2024-07-09 11:05 ` [PATCH 07/11] block: Add missing entries from cmd_flag_name[] John Garry
2024-07-09 23:08   ` kernel test robot
2024-07-09 11:05 ` [PATCH 08/11] block: Catch possible entries missing " John Garry
2024-07-09 11:05 ` [PATCH 09/11] block: Make RQF_x as an enum John Garry
2024-07-09 11:23   ` Christoph Hellwig [this message]
2024-07-09 11:51     ` John Garry
2024-07-09 11:05 ` [PATCH 10/11] block: Add zone write plugging entry to rqf_name[] John Garry
2024-07-09 11:05 ` [PATCH 11/11] block: Catch possible entries missing from rqf_name[] John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240709112318.GA5358@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=john.g.garry@oracle.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox