From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: axboe@kernel.dk, hch@lst.de, martin.petersen@oracle.com,
linux-block@vger.kernel.org, kbusch@kernel.org
Subject: Re: [PATCH 1/2] block: Read max write zeroes once for __blkdev_issue_write_zeroes()
Date: Thu, 15 Aug 2024 14:40:47 +0200 [thread overview]
Message-ID: <20240815124047.GA7803@lst.de> (raw)
In-Reply-To: <20240815082755.105242-2-john.g.garry@oracle.com>
On Thu, Aug 15, 2024 at 08:27:54AM +0000, John Garry wrote:
> +/*
> + * Pass bio_write_zeroes_limit() return value in @limit, as the return
> + * value may change after a REQ_OP_WRITE_ZEROES is issued.
> + */
I don't think that really helps all that much to explain the issue,
which is about SCSI not having an ahead of time flag that reliably
works for write same support, which makes it clear the limit to 0 on
the first I/O completion. Maybe you can actually spell this out?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-08-15 12:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 8:27 [PATCH 0/2] block: Fix __blkdev_issue_write_zeroes() limit handling John Garry
2024-08-15 8:27 ` [PATCH 1/2] block: Read max write zeroes once for __blkdev_issue_write_zeroes() John Garry
2024-08-15 12:40 ` Christoph Hellwig [this message]
2024-08-15 13:29 ` John Garry
2024-08-15 15:26 ` Christoph Hellwig
2024-08-15 15:38 ` John Garry
2024-08-15 15:41 ` Martin K. Petersen
2024-08-15 8:27 ` [PATCH 2/2] block: Drop NULL check in bdev_write_zeroes_sectors() John Garry
2024-08-15 12:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815124047.GA7803@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox