* [PATCH 5.15.y] block: use "unsigned long" for blk_validate_block_size().
@ 2024-08-19 0:05 David Hunter
2024-08-20 1:54 ` David Hunter
0 siblings, 1 reply; 2+ messages in thread
From: David Hunter @ 2024-08-19 0:05 UTC (permalink / raw)
To: stable
Cc: axboe, linux-block, linux-kernel, david.hunter.linux,
Tetsuo Handa, Christoph Hellwig
Since lo_simple_ioctl(LOOP_SET_BLOCK_SIZE) and ioctl(NBD_SET_BLKSIZE) pass
user-controlled "unsigned long arg" to blk_validate_block_size(),
"unsigned long" should be used for validation.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/9ecbf057-4375-c2db-ab53-e4cc0dff953d@i-love.sakura.ne.jp
Signed-off-by: Jens Axboe <axboe@kernel.dk>
(cherry picked from commit 37ae5a0f5287a52cf51242e76ccf198d02ffe495)
Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
---
include/linux/blkdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 905844172cfd..c6d57814988d 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -235,7 +235,7 @@ struct request {
void *end_io_data;
};
-static inline int blk_validate_block_size(unsigned int bsize)
+static inline int blk_validate_block_size(unsigned long bsize)
{
if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize))
return -EINVAL;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 5.15.y] block: use "unsigned long" for blk_validate_block_size().
2024-08-19 0:05 [PATCH 5.15.y] block: use "unsigned long" for blk_validate_block_size() David Hunter
@ 2024-08-20 1:54 ` David Hunter
0 siblings, 0 replies; 2+ messages in thread
From: David Hunter @ 2024-08-20 1:54 UTC (permalink / raw)
To: david.hunter.linux
Cc: axboe, hch, linux-block, linux-kernel, penguin-kernel, stable
Link to version 2:
https://lore.kernel.org/all/20240819002324.2284362-1-david.hunter.linux@gmail.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-20 1:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-19 0:05 [PATCH 5.15.y] block: use "unsigned long" for blk_validate_block_size() David Hunter
2024-08-20 1:54 ` David Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).