From: Yang Ruibin <11162571@vivo.com>
To: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com, Yang Ruibin <11162571@vivo.com>
Subject: [PATCH v3] drivers:block:Use IS_ERR() to check debugfs_create_dir() return value
Date: Fri, 23 Aug 2024 18:10:46 +0800 [thread overview]
Message-ID: <20240823101047.3755190-1-11162571@vivo.com> (raw)
The debugfs_create_dir() function returns error pointers.It
never returns NULL. So use IS_ERR() to check its return value.
Fixes: f40eb99897af ("pktcdvd: remove driver.")
Signed-off-by: Yang Ruibin <11162571@vivo.com>
---
Changes v3:
- Add corresponding fixes.The revert original fixes information
- is used compared to the v2 version
---
drivers/block/pktcdvd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 7cece5884b9c..030b7a063a0b 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -498,7 +498,7 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
if (!pkt_debugfs_root)
return;
pd->dfs_d_root = debugfs_create_dir(pd->disk->disk_name, pkt_debugfs_root);
- if (!pd->dfs_d_root)
+ if (IS_ERR(pd->dfs_d_root))
return;
pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root,
--
2.34.1
next reply other threads:[~2024-08-23 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 10:10 Yang Ruibin [this message]
2024-08-23 10:46 ` [PATCH v3] drivers:block:Use IS_ERR() to check debugfs_create_dir() return value Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823101047.3755190-1-11162571@vivo.com \
--to=11162571@vivo.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox