From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
"Richard W . M . Jones" <rjones@redhat.com>,
Jeff Moyer <jmoyer@redhat.com>,
Jiri Jaburek <jjaburek@redhat.com>,
Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH] block: Fix elv_iosched_local_module handling of "none" scheduler
Date: Tue, 17 Sep 2024 15:05:18 +0200 [thread overview]
Message-ID: <20240917130518.GA32184@lst.de> (raw)
In-Reply-To: <Zul97FvBsVuC1_h3@fedora>
On Tue, Sep 17, 2024 at 09:02:36PM +0800, Ming Lei wrote:
>
> Here 'no_freeze' means that automatic 'freeze queue' isn't needed, or
> it can be named as 'no_auto_freeze'.
>
> Again, 'load_module' is one bad name from interface viewpoint, which is just
> needed by 'scheduler' only.
If we want to reshuffle this we could have a ->store_unfrozen method
that does all the work. But as long as the elevator loading is the
only thing that needs do to unfrozen work I'd just keep things as it
and not rock the boat.
next prev parent reply other threads:[~2024-09-17 13:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 5:32 [PATCH] block: Fix elv_iosched_local_module handling of "none" scheduler Damien Le Moal
2024-09-17 5:53 ` Christoph Hellwig
2024-09-17 12:33 ` Ming Lei
2024-09-17 12:48 ` Damien Le Moal
2024-09-17 13:02 ` Ming Lei
2024-09-17 13:05 ` Christoph Hellwig [this message]
2024-09-17 13:11 ` Jens Axboe
2024-09-17 13:14 ` Christoph Hellwig
2024-09-17 13:17 ` Jens Axboe
2024-09-17 13:18 ` Damien Le Moal
2024-09-17 13:19 ` Jens Axboe
2024-09-17 11:55 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240917130518.GA32184@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=jjaburek@redhat.com \
--cc=jmoyer@redhat.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=rjones@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).