From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Andrey Skvortsov <andrej.skvortzov@gmail.com>,
Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com>,
Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3] zram: don't free statically defined names
Date: Tue, 24 Sep 2024 14:41:51 +0900 [thread overview]
Message-ID: <20240924054151.GL38742@google.com> (raw)
In-Reply-To: <8294e492-5811-44de-8ee2-5f460a065f54@wanadoo.fr>
On (24/09/24 07:21), Christophe JAILLET wrote:
> > > Hi,
> > >
> > > maybe kfree_const() to be more future proof and less verbose?
> >
> > kfree_const() will not work if zram is built as a module. It works
> > only for .rodata for kernel image. [1]
> >
> > 1. https://elixir.bootlin.com/linux/v6.11/source/include/asm-generic/sections.h#L177
> >
>
> If so, then it is likely that it is not correctly used elsewhere.
Oh, apparently there are drivers that use it...
So I suspect it works when you do
kstrdup_const()
kfree_const()
// I only looked at drivers/firmware/arm_scmi/bus.c
kstrdup_const() can't tell module's .rodata so it does plain
kstrdup() and then kfree_const() (for the same reason) does
plain kfree().
But calling kfree_const() on something that has not been
kstrdup_const() is unlikely to work as intended for modules.
So I guess kfree_const() works only when paired with kstrdup_const().
next prev parent reply other threads:[~2024-09-24 5:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 16:48 [PATCH v3] zram: don't free statically defined names Andrey Skvortsov
2024-09-23 17:40 ` Christophe JAILLET
2024-09-23 22:41 ` Andrey Skvortsov
2024-09-24 5:10 ` Sergey Senozhatsky
2024-09-24 5:21 ` Christophe JAILLET
2024-09-24 5:41 ` Sergey Senozhatsky [this message]
2024-09-24 5:49 ` Sergey Senozhatsky
2024-09-24 5:58 ` Sergey Senozhatsky
2024-09-24 6:50 ` Sergey Senozhatsky
2024-09-24 1:46 ` Sergey Senozhatsky
2024-09-24 1:42 ` Sergey Senozhatsky
2024-09-24 5:17 ` Sergey Senozhatsky
2024-09-24 8:15 ` Venkat Rao Bagalkote
2024-09-24 15:56 ` Chris Li
2024-09-24 18:29 ` Chris Li
2024-09-25 0:37 ` Sergey Senozhatsky
2024-09-25 4:04 ` Chris Li
2024-09-27 22:59 ` Chris Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924054151.GL38742@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=andrej.skvortzov@gmail.com \
--cc=axboe@kernel.dk \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=stable@vger.kernel.org \
--cc=venkat88@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).