From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Pankaj Raghav <kernel@pankajraghav.com>
Cc: minchan@kernel.org, senozhatsky@chromium.org,
linux-kernel@vger.kernel.org, axboe@kernel.dk,
p.raghav@samsung.com, linux-block@vger.kernel.org,
gost.dev@samsung.com
Subject: Re: [PATCH 0/5] Improve zram writeback performance
Date: Thu, 26 Sep 2024 13:41:29 +0900 [thread overview]
Message-ID: <20240926044129.GE11458@google.com> (raw)
In-Reply-To: <20230911133430.1824564-1-kernel@pankajraghav.com>
On (23/09/11 15:34), Pankaj Raghav wrote:
> Batching reduces the time of writeback of 4G data to a nvme backing device
> from 68 secs to 15 secs (more than **4x improvement**).
I don't think anyone does that on practice. Excessive writeback wears
out flash storage, so on practice no one writebacks gigabytes of data
all at once, but instead people put daily writeback limits and try to
be flash storage "friendly", which is especially important if your device
has to a lifespan of 7 or 10 years. IOW usually writeback is put under
such constraints that writeback speed is hardly noticeable. So I'm not
sure that the complexity that this patch introduces is justified, to be
honest.
prev parent reply other threads:[~2024-09-26 4:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230911133442eucas1p2f773a475e0a6dc1a448c63884d58c8d3@eucas1p2.samsung.com>
2023-09-11 13:34 ` [PATCH 0/5] Improve zram writeback performance Pankaj Raghav
2023-09-11 13:34 ` [PATCH 1/5] zram: move index preparation to a separate function in writeback_store Pankaj Raghav
2023-09-11 13:34 ` [PATCH 2/5] zram: encapsulate writeback to the backing bdev in a function Pankaj Raghav
2023-09-11 13:34 ` [PATCH 3/5] zram: add alloc_block_bdev_range() and free_block_bdev_range() Pankaj Raghav
2023-09-11 13:34 ` [PATCH 4/5] zram: batch IOs during writeback to improve performance Pankaj Raghav
2023-09-11 13:34 ` [PATCH 5/5] zram: don't overload blk_idx variable in writeback_store() Pankaj Raghav
2023-09-18 13:53 ` [PATCH 0/5] Improve zram writeback performance Pankaj Raghav
2023-09-19 0:33 ` Sergey Senozhatsky
2023-09-19 14:20 ` Pankaj Raghav
2024-09-25 15:53 ` Jassi Brar
2024-09-26 4:33 ` Sergey Senozhatsky
2024-09-29 22:21 ` Jassi Brar
2024-09-26 4:41 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926044129.GE11458@google.com \
--to=senozhatsky@chromium.org \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=kernel@pankajraghav.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).