From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Andreas Hindborg <a.hindborg@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
"Richard W . M . Jones" <rjones@redhat.com>,
Ming Lei <ming.lei@redhat.com>, Jeff Moyer <jmoyer@redhat.com>,
Jiri Jaburek <jjaburek@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH v2] block: Fix elv_iosched_local_module handling of "none" scheduler
Date: Tue, 8 Oct 2024 06:20:05 +0200 [thread overview]
Message-ID: <20241008042005.GA20982@lst.de> (raw)
In-Reply-To: <ee7bcfc3-ce25-4cdd-95c0-c96585128424@kernel.org>
On Tue, Oct 08, 2024 at 07:48:10AM +0900, Damien Le Moal wrote:
> Yes, ->load_module() should return 0 on success and negative error code on
> error. Otherwise, a positive error may be interpreted by user space as a success
> write to the sysfs attribute. Adding a comment for that will be good too.
>
> Care to send a patch ?
It should not return anything at all as alreaday said last round.
Jens just asked for that to be sent layer, so I guess I'll do it now.
next prev parent reply other threads:[~2024-10-08 4:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 13:32 [PATCH v2] block: Fix elv_iosched_local_module handling of "none" scheduler Damien Le Moal
2024-09-17 13:33 ` Christoph Hellwig
2024-09-17 14:34 ` Jens Axboe
2024-10-07 10:51 ` Andreas Hindborg
2024-10-07 22:48 ` Damien Le Moal
2024-10-08 4:20 ` Christoph Hellwig [this message]
2024-10-08 5:13 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008042005.GA20982@lst.de \
--to=hch@lst.de \
--cc=a.hindborg@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=jjaburek@redhat.com \
--cc=jmoyer@redhat.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=rjones@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).