From: Christoph Hellwig <hch@lst.de>
To: "Matias Bjørling" <m@bjorling.me>
Cc: kbusch@kernel.org, hch@lst.de, dlemoal@kernel.org,
cassel@kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
wangyugui@e16-tech.com, martin.petersen@oracle.com, hare@suse.de,
"Matias Bjørling" <matias.bjorling@wdc.com>
Subject: Re: [PATCH 1/3 v2] nvme: make independent ns identify default
Date: Fri, 11 Oct 2024 10:14:52 +0200 [thread overview]
Message-ID: <20241011081452.GA3337@lst.de> (raw)
In-Reply-To: <20241010123951.1226105-2-m@bjorling.me>
On Thu, Oct 10, 2024 at 02:39:49PM +0200, Matias Bjørling wrote:
> From: Matias Bjørling <matias.bjorling@wdc.com>
>
> The NVMe 2.0 specification adds an independent identify namespace
> data structure that contains generic attributes that apply to all
> namespace types. Some attributes carry over from the NVM command set
> identify namespace data structure, and others are new.
>
> Currently, the data structure only considered when CRIMS is enabled or
> when the namespace type is key-value.
>
> However, the independent namespace data structure
> is mandatory for devices that implement features from the 2.0+
> specification. Therefore, we can check this data structure first. If
> unavailable, retrieve the generic attributes from the NVM command set
> identify namespace data structure.
FYI, I still disagree with this for the same reason as before.
Assuming we're not really going to see hard drivers I'd be fine
with using it by default for 2.0 (or better even 2.1) by default.
next prev parent reply other threads:[~2024-10-11 8:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 12:39 [PATCH 0/3 v2] nvme: add rotational support Matias Bjørling
2024-10-10 12:39 ` [PATCH 1/3 v2] nvme: make independent ns identify default Matias Bjørling
2024-10-11 8:14 ` Christoph Hellwig [this message]
2024-10-11 17:32 ` Matias Bjørling
2024-11-01 22:45 ` Keith Busch
2024-11-04 13:24 ` Matias Bjørling
2024-11-05 11:04 ` Christoph Hellwig
2024-10-10 12:39 ` [PATCH 2/3 v2] nvme: add rotational support Matias Bjørling
2024-10-11 8:15 ` Christoph Hellwig
2024-10-10 12:39 ` [PATCH 3/3 v2] nvmet: " Matias Bjørling
2024-10-11 8:22 ` Christoph Hellwig
2024-10-11 17:11 ` kernel test robot
2024-11-05 3:00 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241011081452.GA3337@lst.de \
--to=hch@lst.de \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
--cc=martin.petersen@oracle.com \
--cc=matias.bjorling@wdc.com \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).