From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
YangYang <yang.yang@vivo.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] block: also mark disk-owned queues as dying in __blk_mark_disk_dead
Date: Sat, 19 Oct 2024 10:25:41 +0900 [thread overview]
Message-ID: <20241019012541.GD1279924@google.com> (raw)
In-Reply-To: <Zw_BBgrVAJrxrfpe@fedora>
On (24/10/16 21:35), Ming Lei wrote:
> On Wed, Oct 09, 2024 at 01:38:20PM +0200, Christoph Hellwig wrote:
> > When del_gendisk shuts down access to a gendisk, it could lead to a
> > deadlock with sd or, which try to submit passthrough SCSI commands from
> > their ->release method under open_mutex. The submission can be blocked
> > in blk_enter_queue while del_gendisk can't get to actually telling them
> > top stop and wake them up.
>
> When ->release() waits in blk_enter_queue(), the following code block
>
> mutex_lock(&disk->open_mutex);
> __blk_mark_disk_dead(disk);
> xa_for_each_start(&disk->part_tbl, idx, part, 1)
> drop_partition(part);
> mutex_unlock(&disk->open_mutex);
blk_enter_queue()->schedule() holds ->open_mutex, so that block
of code sleeps on ->open_mutex. We can't drain under ->open_mutex.
next prev parent reply other threads:[~2024-10-19 1:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 11:38 try to avoid del_gendisk vs passthrough from ->release deadlocks v2 Christoph Hellwig
2024-10-09 11:38 ` [PATCH 1/2] block: also mark disk-owned queues as dying in __blk_mark_disk_dead Christoph Hellwig
2024-10-09 12:31 ` Sergey Senozhatsky
2024-10-09 12:41 ` Christoph Hellwig
2024-10-09 12:43 ` Sergey Senozhatsky
2024-10-09 13:49 ` Jens Axboe
2024-10-16 4:14 ` YangYang
2024-10-16 11:09 ` Ming Lei
2024-10-16 12:32 ` Christoph Hellwig
2024-10-16 12:49 ` Ming Lei
2024-10-16 13:35 ` Ming Lei
2024-10-19 1:25 ` Sergey Senozhatsky [this message]
2024-10-19 12:32 ` Ming Lei
2024-10-19 12:37 ` Sergey Senozhatsky
2024-10-19 12:50 ` Ming Lei
2024-10-19 12:58 ` Sergey Senozhatsky
2024-10-19 13:09 ` Ming Lei
2024-10-19 13:50 ` Sergey Senozhatsky
2024-10-19 15:03 ` Ming Lei
2024-10-19 15:11 ` Sergey Senozhatsky
2024-10-19 15:40 ` Sergey Senozhatsky
2024-10-28 5:44 ` Sergey Senozhatsky
2024-10-09 11:38 ` [PATCH 2/2] block: mark the disk dead before taking open_mutx in del_gendisk Christoph Hellwig
2024-10-16 4:15 ` YangYang
2024-10-16 2:09 ` try to avoid del_gendisk vs passthrough from ->release deadlocks v2 Sergey Senozhatsky
-- strict thread matches above, loose matches on Subject: below --
2024-10-08 11:57 RFC: try to avoid del_gendisk vs passthrough from ->release deadlocks Christoph Hellwig
2024-10-08 11:57 ` [PATCH 1/2] block: also mark disk-owned queues as dying in __blk_mark_disk_dead Christoph Hellwig
2024-10-09 5:06 ` Sergey Senozhatsky
2024-10-09 7:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241019012541.GD1279924@google.com \
--to=senozhatsky@chromium.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yang.yang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).