From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Peter Zijlstra <peterz@infradead.org>,
Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>, Ingo Molnar <mingo@redhat.com>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH 1/3] blk-mq: add non_owner variant of start_freeze/unfreeze queue APIs
Date: Wed, 23 Oct 2024 14:19:24 +0200 [thread overview]
Message-ID: <20241023121924.GA28777@lst.de> (raw)
In-Reply-To: <20241023095438.3451156-2-ming.lei@redhat.com>
> +/*
> + * non_owner variant of blk_freeze_queue_start
> + *
> + * The queue needn't to be unfreeze in current task, and non-owner use is
> + * fragile and easy to cause race, please try your best to avoid it
Maybe say:
Unlike blk_freeze_queue_start, the queue doesn't need to be unfrozen
by the same task. This is fragile and should not be used if at all
possible.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-10-23 12:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 9:54 [PATCH 0/3] block: model freeze/enter queue as lock for lockdep Ming Lei
2024-10-23 9:54 ` [PATCH 1/3] blk-mq: add non_owner variant of start_freeze/unfreeze queue APIs Ming Lei
2024-10-23 12:19 ` Christoph Hellwig [this message]
2024-10-23 9:54 ` [PATCH 2/3] nvme: core: switch to non_owner variant of start_freeze/unfreeze queue Ming Lei
2024-10-23 12:21 ` Christoph Hellwig
2024-10-24 1:43 ` Ming Lei
2024-10-24 5:00 ` Christoph Hellwig
2024-10-24 6:43 ` Ming Lei
2024-10-23 9:54 ` [PATCH 3/3] block: model freeze & enter queue as lock for supporting lockdep Ming Lei
2024-10-23 12:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023121924.GA28777@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=boqun.feng@gmail.com \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).