From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, ushankar@purestorage.com,
xizhang@purestorage.com, joshi.k@samsung.com,
anuj20.g@samsung.com, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: fix queue limits checks in blk_rq_map_user_bvec for real
Date: Mon, 28 Oct 2024 10:20:27 +0100 [thread overview]
Message-ID: <20241028092027.GA29592@lst.de> (raw)
In-Reply-To: <3ba278c0-041e-4b07-91c5-c7bdf4bff8a8@oracle.com>
On Fri, Oct 25, 2024 at 09:43:04PM +0100, John Garry wrote:
> On 25/10/2024 12:58, Christoph Hellwig wrote:
>> + /* check that the data layout matches the hardware restrictions */
>> + ret = bio_split_rw_at(bio, lim, &nsegs, lim->max_hw_sectors);
>
> eh, but doesn't bio_split_rw_at() accept bytes (and not a value in sectors)
> for max size?
Yes. Thanks for the careful review, I've sent out a new version.
(and this really helped me finding a bug I had been debugging in
another user of this helper :))
prev parent reply other threads:[~2024-10-28 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 11:58 [PATCH] block: fix queue limits checks in blk_rq_map_user_bvec for real Christoph Hellwig
2024-10-25 18:31 ` Uday Shankar
2024-10-25 18:52 ` Keith Busch
2024-10-25 20:43 ` John Garry
2024-10-28 9:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028092027.GA29592@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=ushankar@purestorage.com \
--cc=xizhang@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).