From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org, io-uring@vger.kernel.org,
linux-fsdevel@vger.kernel.org, hch@lst.de, joshi.k@samsung.com,
javier.gonz@samsung.com, bvanassche@acm.org,
Keith Busch <kbusch@kernel.org>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCHv9 2/7] block: introduce max_write_hints queue limit
Date: Mon, 28 Oct 2024 12:51:32 +0100 [thread overview]
Message-ID: <20241028115132.GB8517@lst.de> (raw)
In-Reply-To: <20241025213645.3464331-3-kbusch@meta.com>
On Fri, Oct 25, 2024 at 02:36:40PM -0700, Keith Busch wrote:
> +static inline unsigned short bdev_max_write_hints(struct block_device *bdev)
> +{
> + return queue_max_write_hints(bdev_get_queue(bdev));
> +}
As pointed out by Bart last time, you can't simply give the write hints
to all block device. Assume we'd want to wire up the write stream based
separate to f2fs (which btw would be a good demonstration), and you'd
have two different f2fs file systems on separate partitions that'd
now start sharing the write streams if they simply started from stream
1. Same for our pending XFS data placement work.
next prev parent reply other threads:[~2024-10-28 11:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 21:36 [PATCHv9 0/7] write hints with nvme fdp, scsi streams Keith Busch
2024-10-25 21:36 ` [PATCHv9 1/7] block: use generic u16 for write hints Keith Busch
2024-10-28 18:19 ` Bart Van Assche
2024-10-28 18:38 ` Keith Busch
2024-10-25 21:36 ` [PATCHv9 2/7] block: introduce max_write_hints queue limit Keith Busch
2024-10-28 11:51 ` Christoph Hellwig [this message]
2024-10-28 11:52 ` Christoph Hellwig
2024-10-25 21:36 ` [PATCHv9 3/7] block: allow ability to limit partition write hints Keith Busch
2024-10-28 11:58 ` Christoph Hellwig
2024-10-28 14:49 ` Keith Busch
2024-10-28 14:40 ` Kanchan Joshi
2024-10-28 18:27 ` Bart Van Assche
2024-10-28 19:46 ` Keith Busch
2024-10-25 21:36 ` [PATCHv9 4/7] block, fs: add write hint to kiocb Keith Busch
2024-10-28 11:59 ` Christoph Hellwig
2024-10-28 14:38 ` Keith Busch
2024-10-28 16:08 ` Christoph Hellwig
2024-10-25 21:36 ` [PATCHv9 5/7] io_uring: enable per-io hinting capability Keith Busch
2024-10-29 12:46 ` Anuj gupta
2024-10-25 21:36 ` [PATCHv9 7/7] scsi: set permanent stream count in block limits Keith Busch
2024-10-28 16:13 ` Bart Van Assche
2024-10-29 7:10 ` Hannes Reinecke
2024-10-28 11:49 ` [PATCHv9 0/7] write hints with nvme fdp, scsi streams Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028115132.GB8517@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=io-uring@vger.kernel.org \
--cc=javier.gonz@samsung.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).