From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [PATCH 2/5] block: fix bio_split_rw_at to take zone_write_granularity into account
Date: Mon, 4 Nov 2024 07:26:30 +0100 [thread overview]
Message-ID: <20241104062647.91160-3-hch@lst.de> (raw)
In-Reply-To: <20241104062647.91160-1-hch@lst.de>
Otherwise it can create unaligned writes on zoned devices.
Fixes: a805a4fa4fa3 ("block: introduce zone_write_granularity limit")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/blk-merge.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index f440919b6c6f..4e6c0a52009c 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -287,6 +287,14 @@ static bool bvec_split_segs(const struct queue_limits *lim,
return len > 0 || bv->bv_len > max_len;
}
+static unsigned int bio_split_alignment(struct bio *bio,
+ const struct queue_limits *lim)
+{
+ if (op_is_write(bio_op(bio)) && lim->zone_write_granularity)
+ return lim->zone_write_granularity;
+ return lim->logical_block_size;
+}
+
/**
* bio_split_rw_at - check if and where to split a read/write bio
* @bio: [in] bio to be split
@@ -349,7 +357,7 @@ int bio_split_rw_at(struct bio *bio, const struct queue_limits *lim,
* split size so that each bio is properly block size aligned, even if
* we do not use the full hardware limits.
*/
- bytes = ALIGN_DOWN(bytes, lim->logical_block_size);
+ bytes = ALIGN_DOWN(bytes, bio_split_alignment(bio, lim));
/*
* Bio splitting may cause subtle trouble such as hang when doing sync
--
2.45.2
next prev parent reply other threads:[~2024-11-04 6:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 6:26 fix a few zoned append issues v2 (now with Ccs) Christoph Hellwig
2024-11-04 6:26 ` [PATCH 1/5] block: take chunk_sectors into account in bio_split_write_zeroes Christoph Hellwig
2024-11-07 12:04 ` Damien Le Moal
2024-11-11 16:08 ` (subset) " Jens Axboe
2024-11-04 6:26 ` Christoph Hellwig [this message]
2024-11-07 12:05 ` [PATCH 2/5] block: fix bio_split_rw_at to take zone_write_granularity into account Damien Le Moal
2024-11-08 7:07 ` Johannes Thumshirn
2024-11-04 6:26 ` [PATCH 3/5] block: lift bio_is_zone_append to bio.h Christoph Hellwig
2024-11-08 7:08 ` Johannes Thumshirn
2024-11-04 6:26 ` [PATCH 4/5] btrfs: use bio_is_zone_append in the completion handler Christoph Hellwig
2024-11-08 7:08 ` Johannes Thumshirn
2024-11-04 6:26 ` [PATCH 5/5] btrfs: split bios to the fs sector size boundary Christoph Hellwig
2024-11-08 7:09 ` Johannes Thumshirn
2024-11-08 14:48 ` fix a few zoned append issues v2 (now with Ccs) Christoph Hellwig
2024-11-08 15:03 ` David Sterba
2024-12-03 17:01 ` David Sterba
2024-12-04 0:17 ` Christoph Hellwig
2024-12-04 6:13 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104062647.91160-3-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=damien.lemoal@wdc.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox