From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH] loop: Use bdev limit helpers for configuring discard
Date: Mon, 4 Nov 2024 08:47:06 +0100 [thread overview]
Message-ID: <20241104074706.GA20887@lst.de> (raw)
In-Reply-To: <629883c0-9269-4820-801c-a5ed6e4b2803@oracle.com>
On Fri, Nov 01, 2024 at 09:08:51AM +0000, John Garry wrote:
>> ok, I see that set in blk_validate_limits()
>
> BTW, can the check for granularity ever fail in
> queue_limit_discard_alignment()
>
> static unsigned int queue_limit_discard_alignment(...)
> {
> ...
>
> granularity = lim->discard_granularity >> SECTOR_SHIFT;
> if (!granularity)
> return 0;
lim->discard_granularity is always set to SECTOR_SIZE or large,
so granularity can't be 0 here.
prev parent reply other threads:[~2024-11-04 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 11:19 [PATCH] loop: Use bdev limit helpers for configuring discard John Garry
2024-10-30 13:24 ` Jens Axboe
2024-10-30 14:06 ` Christoph Hellwig
2024-10-30 14:13 ` John Garry
2024-11-01 9:08 ` John Garry
2024-11-04 7:47 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104074706.GA20887@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).