From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Matias Bjørling" <m@bjorling.me>,
dlemoal@kernel.org, cassel@kernel.org,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, wangyugui@e16-tech.com,
martin.petersen@oracle.com, hare@suse.de,
"Matias Bjørling" <matias.bjorling@wdc.com>
Subject: Re: [PATCH 1/3 v2] nvme: make independent ns identify default
Date: Tue, 5 Nov 2024 12:04:35 +0100 [thread overview]
Message-ID: <20241105110435.GA1822@lst.de> (raw)
In-Reply-To: <ZyVZ_T4HtnqSWTm0@kbusch-mbp.dhcp.thefacebook.com>
On Fri, Nov 01, 2024 at 04:45:17PM -0600, Keith Busch wrote:
> I've got the rest of the required logs and identifications implemented
> in nvmet to support this.
Cool!
> There's one more issue, though, if we do
> restrict the identify to >= 2.0 or 2.1. nvmet reports 1.3, and I suspect
> there's a bit more work than just changing the value of NVMET_DEFAULT_VS
> in order to comply with claiming that version.
I don't think there were a lot of new mandatory requirements added that
we didn't already do, or already we already ignored anyway, but it is
worth a double check.
next prev parent reply other threads:[~2024-11-05 11:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 12:39 [PATCH 0/3 v2] nvme: add rotational support Matias Bjørling
2024-10-10 12:39 ` [PATCH 1/3 v2] nvme: make independent ns identify default Matias Bjørling
2024-10-11 8:14 ` Christoph Hellwig
2024-10-11 17:32 ` Matias Bjørling
2024-11-01 22:45 ` Keith Busch
2024-11-04 13:24 ` Matias Bjørling
2024-11-05 11:04 ` Christoph Hellwig [this message]
2024-10-10 12:39 ` [PATCH 2/3 v2] nvme: add rotational support Matias Bjørling
2024-10-11 8:15 ` Christoph Hellwig
2024-10-10 12:39 ` [PATCH 3/3 v2] nvmet: " Matias Bjørling
2024-10-11 8:22 ` Christoph Hellwig
2024-10-11 17:11 ` kernel test robot
2024-11-05 3:00 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105110435.GA1822@lst.de \
--to=hch@lst.de \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
--cc=martin.petersen@oracle.com \
--cc=matias.bjorling@wdc.com \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).