From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: Prevent potential deadlock in blk_revalidate_disk_zones()
Date: Tue, 26 Nov 2024 11:33:51 +0100 [thread overview]
Message-ID: <20241126103351.GA16537@lst.de> (raw)
In-Reply-To: <20241126085342.173158-1-dlemoal@kernel.org>
On Tue, Nov 26, 2024 at 05:53:42PM +0900, Damien Le Moal wrote:
> in disk_update_zone_resources(). disk_free_zone_resources() is also
> modified to operate with the queue frozen as before by adding calls to
> blk_mq_freeze_queue() and blk_mq_unfreeze_queue().
This now adds a queue freeze to disk_release for zoned device, which
previously didn't have it. Given that at this point no I/O on the
disk is possible, and the freezes are quite expensive that's probably
not a good idea.
> - blk_mq_freeze_queue(q);
> if (ret > 0)
> ret = disk_update_zone_resources(disk, &args);
> else
> pr_warn("%s: failed to revalidate zones\n", disk->disk_name);
> if (ret)
> disk_free_zone_resources(disk);
> - blk_mq_unfreeze_queue(q);
So for a minimal version you could keep the freezing here.
next prev parent reply other threads:[~2024-11-26 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 8:53 [PATCH] block: Prevent potential deadlock in blk_revalidate_disk_zones() Damien Le Moal
2024-11-26 10:33 ` Christoph Hellwig [this message]
2024-11-26 10:39 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241126103351.GA16537@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox