public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Aptel <aaptel@nvidia.com>
To: aaptel@nvidia.com, linux-block@vger.kernel.org,
	linux-nvme@lists.infradead.org
Cc: Daniel Wagner <dwagner@suse.de>,
	Chaitanya Kulkarni <chaitanyak@nvidia.com>,
	Shai Malin <smalin@nvidia.com>,
	Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: [PATCH blktests v5 3/5] nvme/030: only run against kernel soft target
Date: Fri,  6 Dec 2024 15:51:18 +0200	[thread overview]
Message-ID: <20241206135120.5141-4-aaptel@nvidia.com> (raw)
In-Reply-To: <20241206135120.5141-1-aaptel@nvidia.com>

From: Daniel Wagner <dwagner@suse.de>

This tests is exercising the target code and not so much the host side.
The problem with nvme/030 is that it depends on interface to interact
with the target which is not covered by the standard. Thus we can't
run it against an arbitrary target. Just skip it when we run against a
arbitrary target.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 tests/nvme/030 | 1 +
 tests/nvme/rc  | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/tests/nvme/030 b/tests/nvme/030
index 596e411..fe74849 100755
--- a/tests/nvme/030
+++ b/tests/nvme/030
@@ -13,6 +13,7 @@ requires() {
 	_nvme_requires
 	_have_loop
 	_require_nvme_trtype_is_fabrics
+	_require_kernel_nvme_target
 }
 
 set_conditions() {
diff --git a/tests/nvme/rc b/tests/nvme/rc
index 9ad9a52..d1a4c01 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -191,6 +191,14 @@ _require_kernel_nvme_fabrics_feature() {
 	return 0
 }
 
+_require_kernel_nvme_target() {
+	if [[ -n "${nvme_target_control}" ]]; then
+		SKIP_REASONS+=("Linux kernel soft target not available")
+		return 1;
+	fi
+	return 0
+}
+
 _test_dev_nvme_ctrl() {
 	echo "/dev/char/$(cat "${TEST_DEV_SYSFS}/device/dev")"
 }
-- 
2.34.1


  parent reply	other threads:[~2024-12-06 13:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06 13:51 [PATCH blktests v5 0/5] Add support to run against arbitrary targets Aurelien Aptel
2024-12-06 13:51 ` [PATCH blktests v5 1/5] nvme/rc: introduce remote target support Aurelien Aptel
2024-12-09  7:19   ` Chaitanya Kulkarni
2024-12-06 13:51 ` [PATCH blktests v5 2/5] common/nvme: add digest options to __nvme_connect_subsys() Aurelien Aptel
2024-12-09  7:19   ` Chaitanya Kulkarni
2024-12-06 13:51 ` Aurelien Aptel [this message]
2024-12-09  7:20   ` [PATCH blktests v5 3/5] nvme/030: only run against kernel soft target Chaitanya Kulkarni
2024-12-06 13:51 ` [PATCH blktests v5 4/5] contrib: add remote target setup/cleanup script Aurelien Aptel
2024-12-09  7:20   ` Chaitanya Kulkarni
2024-12-06 13:51 ` [PATCH blktests v5 5/5] nvme/055: add test for nvme-tcp zero-copy offload Aurelien Aptel
2024-12-09  7:20   ` Chaitanya Kulkarni
2026-01-28 15:28   ` John Garry
2026-01-29  2:07     ` Shinichiro Kawasaki
2026-01-29 10:28     ` Aurelien Aptel
2024-12-10  8:17 ` [PATCH blktests v5 0/5] Add support to run against arbitrary targets Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241206135120.5141-4-aaptel@nvidia.com \
    --to=aaptel@nvidia.com \
    --cc=chaitanyak@nvidia.com \
    --cc=dwagner@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=smalin@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox