linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: LiviaMedeiros <9@cirno.name>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Minchan Kim <minchan@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Nick Terrell <terrelln@fb.com>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] zram: make default ZSTD compression level configurable
Date: Sat, 7 Dec 2024 12:54:02 +0900	[thread overview]
Message-ID: <20241207035402.GI16709@google.com> (raw)
In-Reply-To: <7d73e19b-f264-4c31-8f5a-fb17b6bc0600@cirno.name>

On (24/12/07 04:16), LiviaMedeiros wrote:
> From: LiviaMedeiros <livia@cirno.name>
> 
> Add support for configuring the default ZSTD compression level for zram
> devices via the CONFIG_ZRAM_DEFAULT_ZSTD_LEVEL configuration option.
> If this option is not set, fallback to zstd_default_clevel() is used.

Please let's not.  Then somebody will need options to .config c/d dicts
for zstd/lz4/lz4hc, acceleration levels for lz4, compression level for
deflate and so on and on and on.

[..]
> I also failed to make something like `echo "algo=zstd level=9" >
> /sys/block/zram3/algorithm_params` work in runtime, but I assume I'm just
> dumb and/or it requires extra steps.

This should work, but you need to configure algo params before you init
zram device (that is _before_ write to disksize device attr).

E.g.

% modprobe zram
% echo zstd > /sys/block/zram0/comp_algorithm
% echo "algo=zstd level=9 dict=/etc/zstd-dict-amd64" > /sys/block/zram0/algorithm_params
% echo 1G > /sys/block/zram0/disksize

      reply	other threads:[~2024-12-07  3:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06 20:16 [PATCH] zram: make default ZSTD compression level configurable LiviaMedeiros
2024-12-07  3:54 ` Sergey Senozhatsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241207035402.GI16709@google.com \
    --to=senozhatsky@chromium.org \
    --cc=9@cirno.name \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=terrelln@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).