From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
dm-devel@lists.linux.dev, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH v2 4/4] dm: Fix dm-zoned-reclaim zone write pointer alignment
Date: Mon, 9 Dec 2024 08:44:08 +0100 [thread overview]
Message-ID: <20241209074408.GA24323@lst.de> (raw)
In-Reply-To: <20241208225758.219228-5-dlemoal@kernel.org>
On Mon, Dec 09, 2024 at 07:57:58AM +0900, Damien Le Moal wrote:
> +int blkdev_issue_zone_zeroout(struct block_device *bdev, sector_t sector,
> + sector_t nr_sects, gfp_t gfp_mask)
Nit: Would blk_zone_issue_zeroout be a better name?
Also I think this needs to be re-ordered before the previous patch to
preserve bisectability.
> +EXPORT_SYMBOL(blkdev_issue_zone_zeroout);
EXPORT_SYMBOL_GPL is used for all other zoned code, I'd do the same
here for consitency.
next prev parent reply other threads:[~2024-12-09 7:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-08 22:57 [PATCH v2 0/4] Zone write plugging fixes Damien Le Moal
2024-12-08 22:57 ` [PATCH v2 1/4] block: Use a zone write plug BIO work for REQ_NOWAIT BIOs Damien Le Moal
2024-12-09 7:44 ` Christoph Hellwig
2024-12-08 22:57 ` [PATCH v2 2/4] block: Ignore REQ_NOWAIT for zone reset and zone finish operations Damien Le Moal
2024-12-09 7:46 ` Christoph Hellwig
2024-12-08 22:57 ` [PATCH v2 3/4] block: Prevent potential deadlocks in zone write plug error recovery Damien Le Moal
2024-12-09 7:57 ` Christoph Hellwig
2024-12-09 8:18 ` Damien Le Moal
2024-12-09 8:21 ` Christoph Hellwig
2024-12-08 22:57 ` [PATCH v2 4/4] dm: Fix dm-zoned-reclaim zone write pointer alignment Damien Le Moal
2024-12-09 7:44 ` Christoph Hellwig [this message]
2024-12-09 8:38 ` Damien Le Moal
2024-12-09 8:39 ` Christoph Hellwig
2024-12-09 8:40 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209074408.GA24323@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).