From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 3/3] block: Fix queue_iostats_passthrough_show()
Date: Mon, 16 Dec 2024 16:56:11 +0100 [thread overview]
Message-ID: <20241216155611.GB24280@lst.de> (raw)
In-Reply-To: <7399171c-6cf3-4e07-b4e5-1d5d362198ba@acm.org>
On Fri, Dec 13, 2024 at 08:26:44AM -0800, Bart Van Assche wrote:
> There are about 16 functions in include/linux/blkdev.h that test a single
> bit in q->queue_flags or q->limits.features. Do you really want
> me to convert all these macros into inline functions?
Given that all of them could leak the __bitwise type that could be
worthwhile. Alternatively we could also take a hard look at these
helpers and check if they are even worth having and otherwise just
open code the check for the bits.
next prev parent reply other threads:[~2024-12-16 15:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 21:29 [PATCH 0/3] Three small block layer patches Bart Van Assche
2024-12-12 21:29 ` [PATCH 1/3] mq-deadline: Remove a local variable Bart Van Assche
2024-12-13 4:44 ` Christoph Hellwig
2024-12-13 5:36 ` Nitesh Shetty
2024-12-13 7:26 ` Johannes Thumshirn
2024-12-12 21:29 ` [PATCH 2/3] blk-mq: Clean up blk_mq_requeue_work() Bart Van Assche
2024-12-13 4:44 ` Christoph Hellwig
2024-12-13 5:34 ` Nitesh Shetty
2024-12-13 7:26 ` Johannes Thumshirn
2024-12-12 21:29 ` [PATCH 3/3] block: Fix queue_iostats_passthrough_show() Bart Van Assche
2024-12-13 4:46 ` Christoph Hellwig
2024-12-13 16:26 ` Bart Van Assche
2024-12-16 15:56 ` Christoph Hellwig [this message]
2024-12-13 15:09 ` [PATCH 0/3] Three small block layer patches Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216155611.GB24280@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox