From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [PATCH 2/2] blk-mq: Move more error handling into blk_mq_submit_bio()
Date: Tue, 17 Dec 2024 05:18:19 +0100 [thread overview]
Message-ID: <20241217041819.GB15286@lst.de> (raw)
In-Reply-To: <20241216201901.2670237-3-bvanassche@acm.org>
On Mon, Dec 16, 2024 at 12:19:01PM -0800, Bart Van Assche wrote:
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 8d2aab4d9ba9..80eb91296142 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2971,8 +2971,6 @@ static struct request *blk_mq_get_new_requests(struct request_queue *q,
> if (rq)
> return rq;
> rq_qos_cleanup(q, bio);
> - if (bio->bi_opf & REQ_NOWAIT)
> - bio_wouldblock_error(bio);
> return NULL;
Please turn this into:
if (rq)
rq_qos_cleanup(q, bio);
return rq;
Otherwise this looks like a nice cleanup.
next prev parent reply other threads:[~2024-12-17 4:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 20:18 [PATCH 0/2] Move blk_mq_submit_bio() error handling Bart Van Assche
2024-12-16 20:19 ` [PATCH 1/2] block: Optimize blk_mq_submit_bio() for the cache hit scenario Bart Van Assche
2024-12-17 4:16 ` Christoph Hellwig
2024-12-17 19:22 ` Bart Van Assche
2024-12-17 21:15 ` Jens Axboe
2024-12-18 6:59 ` Christoph Hellwig
2024-12-18 18:22 ` Bart Van Assche
2024-12-16 20:19 ` [PATCH 2/2] blk-mq: Move more error handling into blk_mq_submit_bio() Bart Van Assche
2024-12-17 4:18 ` Christoph Hellwig [this message]
2024-12-17 21:06 ` Bart Van Assche
2024-12-18 7:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217041819.GB15286@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).